[Embedder] Support render texture for vulkan - #188855

flutter/flutter@e89fd0a...d03768e

2026-10-02 [email protected] Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694)
2026-10-02 [email protected] [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005)
2026-10-02 [email protected] Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692)
2026-10-02 [email protected] Remove unused Fuchsia sysmem header files (flutter/flutter#193244)
2026-10-02 [email protected] [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968)
2026-10-02 [email protected] [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222)
2026-10-02 [email protected] [Embedder] Support render texture for vulkan (flutter/flutter#188855)
2026-10-02 [email protected] Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429)
2026-10-02 [email protected] Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714)
2026-10-02 [email protected] [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836)
2026-10-02 [email protected] [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963)
2026-10-02 [email protected] [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678)
2026-10-02 [email protected] [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427)
2026-10-02 [email protected] Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676)
2026-10-01 [email protected] Fix analysis failures due to missing `const` (flutter/flutter#193685)
2026-10-01 [email protected] Removes a11y_assessment app (flutter/flutter#193671)
2026-10-01 [email protected] test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529)
2026-10-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193666)
2026-10-01 [email protected] Avoid using relative path in Process.start (flutter/flutter#193664)
2026-10-01 [email protected] [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488)
2026-10-01 [email protected] ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580)
2026-10-01 [email protected] [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591)
2026-10-01 [email protected] [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Adopt the Vulkan external texture embedder API from flutter/flutter#188855
so plugins can hand the engine a VkImage on the Vulkan backends, the
counterpart of kFlutterDesktopGpuSurfaceTypeGlTexture2D on EGL.

API
- embedder.h: add FlutterVulkanExternalTexture,
  FlutterVulkanTextureFrameCallback and
  FlutterVulkanRendererConfig::external_texture_frame_callback, verbatim
  from the merged upstream header.
- flutter_texture_registrar.h: new kFlutterDesktopGpuSurfaceTypeVkImage;
  the descriptor's handle points to a FlutterDesktopVulkanImage
  {VkImage, VkFormat}. The GPU-surface callback runs on the raster thread
  on every resolve, so a producer can cycle images. The header documents
  the full contract: device, layout, host sync, image lifetime, supported
  formats, and asynchronous unregistration.

Resolve and lifetime (flutter_desktop_vk_texture.{h,cc})
- The plugin callback runs with no registrar lock held, so it may
  host-sync or (un)register textures without stalling or deadlocking
  other plugins.
- Each frame handed to the engine carries an embedder token instead of
  the plugin's release context. The plugin's release_callback fires
  exactly once even if the engine reports a frame twice (its Skia path
  can: BorrowTextureFrom releases on failure and the engine releases
  again).
- Unregistration completes only after the engine has released every
  frame and no plugin callback is running, so a plugin cannot free an
  image the engine is still sampling. With a completion callback it
  never blocks; without one it waits for an in-flight callback (not a
  re-entrant one) and warns if the engine still holds frames.
- Rejects formats the engine cannot sample on both renderers, YCbCr
  formats unless the device enabled samplerYcbcrConversion (creating a
  conversion without it is undefined behavior), and sizes beyond
  maxImageDimension2D. A rejected frame goes straight back to the
  plugin.
- The token table is leaked so engine threads releasing frames during
  exit() never touch a destroyed map; tokens skip 0 and any still in use
  after a 32-bit wrap.

Backends
- wayland_vulkan, drm_kms_vulkan, headless_vulkan: wire the callback.
  BackendVulkanContext reports sampler_ycbcr_conversion (wayland_vulkan
  enables it when supported; the others do not request it).
- wayland_vulkan set vulkan.struct_size to sizeof(FlutterRendererConfig);
  it now uses sizeof(FlutterVulkanRendererConfig).

Tests
- vk_external_texture-test (21 cases, no GPU or GL): resolve,
  validation, ABI bounds, idempotent release, deferred and re-entrant
  unregistration, lock-free callback. Clean under TSan and ASan+UBSan.

On an engine without #188855 the config field is ignored and VkImage
textures register but never resolve. Pixel-buffer textures still
resolve only on GL backends.

Co-Authored-By: Claude Fable 5.1 <[email protected]>

Adopt the Vulkan external texture embedder API from flutter/flutter#188855
so plugins can hand the engine a VkImage on the Vulkan backends, the
counterpart of kFlutterDesktopGpuSurfaceTypeGlTexture2D on EGL.

API
- embedder.h: add FlutterVulkanExternalTexture,
  FlutterVulkanTextureFrameCallback and
  FlutterVulkanRendererConfig::external_texture_frame_callback, verbatim
  from the merged upstream header.
- flutter_texture_registrar.h: new kFlutterDesktopGpuSurfaceTypeVkImage;
  the descriptor's handle points to a FlutterDesktopVulkanImage
  {VkImage, VkFormat}. The GPU-surface callback runs on the raster thread
  on every resolve, so a producer can cycle images. The header documents
  the full contract: device, layout, host sync, image lifetime, supported
  formats, and asynchronous unregistration.

Resolve and lifetime (flutter_desktop_vk_texture.{h,cc})
- The plugin callback runs with no registrar lock held, so it may
  host-sync or (un)register textures without stalling or deadlocking
  other plugins.
- Each frame handed to the engine carries an embedder token instead of
  the plugin's release context. The plugin's release_callback fires
  exactly once even if the engine reports a frame twice (its Skia path
  can: BorrowTextureFrom releases on failure and the engine releases
  again).
- Unregistration completes only after the engine has released every
  frame and no plugin callback is running, so a plugin cannot free an
  image the engine is still sampling. With a completion callback it
  never blocks; without one it waits for an in-flight callback (not a
  re-entrant one) and warns if the engine still holds frames.
- Rejects formats the engine cannot sample on both renderers, YCbCr
  formats unless the device enabled samplerYcbcrConversion (creating a
  conversion without it is undefined behavior), and sizes beyond
  maxImageDimension2D. A rejected frame goes straight back to the
  plugin.
- The token table is leaked so engine threads releasing frames during
  exit() never touch a destroyed map; tokens skip 0 and any still in use
  after a 32-bit wrap.

Backends
- wayland_vulkan, drm_kms_vulkan, headless_vulkan: wire the callback.
  BackendVulkanContext reports sampler_ycbcr_conversion (wayland_vulkan
  enables it when supported; the others do not request it).
- wayland_vulkan set vulkan.struct_size to sizeof(FlutterRendererConfig);
  it now uses sizeof(FlutterVulkanRendererConfig).

Tests
- vk_external_texture-test (21 cases, no GPU or GL): resolve,
  validation, ABI bounds, idempotent release, deferred and re-entrant
  unregistration, lock-free callback. Clean under TSan and ASan+UBSan.

On an engine without #188855 the config field is ignored and VkImage
textures register but never resolve. Pixel-buffer textures still
resolve only on GL backends.

Adopt the Vulkan external texture embedder API from flutter/flutter#188855
so plugins can hand the engine a VkImage on the Vulkan backends, the
counterpart of kFlutterDesktopGpuSurfaceTypeGlTexture2D on EGL.

API
- embedder.h: add FlutterVulkanExternalTexture,
  FlutterVulkanTextureFrameCallback and
  FlutterVulkanRendererConfig::external_texture_frame_callback, verbatim
  from the merged upstream header.
- flutter_texture_registrar.h: new kFlutterDesktopGpuSurfaceTypeVkImage;
  the descriptor's handle points to a FlutterDesktopVulkanImage
  {VkImage, VkFormat}. The GPU-surface callback runs on the raster thread
  on every resolve, so a producer can cycle images. The header documents
  the full contract: device, layout, host sync, image lifetime, supported
  formats, and asynchronous unregistration.

Resolve and lifetime (flutter_desktop_vk_texture.{h,cc})
- The plugin callback runs with no registrar lock held, so it may
  host-sync or (un)register textures without stalling or deadlocking
  other plugins.
- Each frame handed to the engine carries an embedder token instead of
  the plugin's release context. The plugin's release_callback fires
  exactly once even if the engine reports a frame twice (its Skia path
  can: BorrowTextureFrom releases on failure and the engine releases
  again).
- Unregistration completes only after the engine has released every
  frame and no plugin callback is running, so a plugin cannot free an
  image the engine is still sampling. With a completion callback it
  never blocks; without one it waits for an in-flight callback (not a
  re-entrant one) and warns if the engine still holds frames.
- Rejects formats the engine cannot sample on both renderers, YCbCr
  formats unless the device enabled samplerYcbcrConversion (creating a
  conversion without it is undefined behavior), and sizes beyond
  maxImageDimension2D. A rejected frame goes straight back to the
  plugin.
- The token table is leaked so engine threads releasing frames during
  exit() never touch a destroyed map; tokens skip 0 and any still in use
  after a 32-bit wrap.

Backends
- wayland_vulkan, drm_kms_vulkan, headless_vulkan: wire the callback.
  BackendVulkanContext reports sampler_ycbcr_conversion (wayland_vulkan
  enables it when supported; the others do not request it).
- wayland_vulkan set vulkan.struct_size to sizeof(FlutterRendererConfig);
  it now uses sizeof(FlutterVulkanRendererConfig).

Tests
- vk_external_texture-test (21 cases, no GPU or GL): resolve,
  validation, ABI bounds, idempotent release, deferred and re-entrant
  unregistration, lock-free callback. Clean under TSan and ASan+UBSan.

On an engine without #188855 the config field is ignored and VkImage
textures register but never resolve. Pixel-buffer textures still
resolve only on GL backends.

Signed-off-by: Joel Winarske <[email protected]>