Repository navigation
Document that enableSuggestions: false can disable keyboard languages on Android - #192714
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for enableSuggestions in TextInputConfiguration to explain how disabling suggestions on Android can restrict certain keyboard languages due to the underlying TYPE_TEXT_FLAG_NO_SUGGESTIONS flag. The review feedback suggests removing the added link to the GitHub issue from the public API documentation, as it is internal and redundant given the clear explanation already provided.
| /// | ||
| /// * <https://developer.android.com/reference/android/text/InputType.html#TYPE_TEXT_FLAG_NO_SUGGESTIONS> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Done, removed the issue link.
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for improving the docs! Looks like you are right based on the Android docs for TYPE_TEXT_FLAG_NO_SUGGESTIONS.
|
Thanks for the review, @justinmc! Could someone add the CICD label so the tests can run? |
7178538 to
d56c36b
Compare
|
autosubmit label was removed for flutter/flutter/192714, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
1) Android 输入法被换成系统「安全键盘」(搜狗/日文输入法调不出来、打不出日文) 根因:编辑框设了 enableSuggestions: false,Android 会打上 「不要建议/不要个性化学习」标记,第三方输入法据此退回受限键盘 (flutter/flutter#192714、flutter-team-archive/engine#46037)。 修复:enableSuggestions 改回 true 并加注释防止复发;autocorrect 仍为 false (只是不自动改写用词,不影响输入法调起)。 2) 杀掉 App 重开后视频进度回到 0 根因:open() 之后紧接着的 seek 在 Android 上会被丢掉(时长/视频输出未就绪)。 修复:先等 player.state.duration > 0(最多 4 秒)再 seek,seek 后核对位置, 偏差 > 2 秒就补一次(最多 5 次)。 文档:测试清单第 13/14 条、三份 README 疑难解答各加 2 行、release-notes-v1.0.3.md 版本号 1.0.2+3 -> 1.0.3+4;analyze 零问题、65/65 测试通过。
… on Android Some Android keyboards, like Gboard, disable keyboard languages that rely on suggestions, such as Chinese and Korean, when TYPE_TEXT_FLAG_NO_SUGGESTIONS is set. Fixes flutter#139143
d56c36b to
d59ccc4
Compare
flutter/flutter@e89fd0a...d03768e 2026-10-02 [email protected] Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694) 2026-10-02 [email protected] [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005) 2026-10-02 [email protected] Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692) 2026-10-02 [email protected] Remove unused Fuchsia sysmem header files (flutter/flutter#193244) 2026-10-02 [email protected] [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968) 2026-10-02 [email protected] [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222) 2026-10-02 [email protected] [Embedder] Support render texture for vulkan (flutter/flutter#188855) 2026-10-02 [email protected] Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429) 2026-10-02 [email protected] Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714) 2026-10-02 [email protected] [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836) 2026-10-02 [email protected] [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963) 2026-10-02 [email protected] [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678) 2026-10-02 [email protected] [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427) 2026-10-02 [email protected] Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676) 2026-10-01 [email protected] Fix analysis failures due to missing `const` (flutter/flutter#193685) 2026-10-01 [email protected] Removes a11y_assessment app (flutter/flutter#193671) 2026-10-01 [email protected] test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529) 2026-10-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193666) 2026-10-01 [email protected] Avoid using relative path in Process.start (flutter/flutter#193664) 2026-10-01 [email protected] [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488) 2026-10-01 [email protected] ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580) 2026-10-01 [email protected] [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591) 2026-10-01 [email protected] [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
enableSuggestions: falsesets Android'sTYPE_TEXT_FLAG_NO_SUGGESTIONSflag. Some keyboards, like Gboard, respond by disabling keyboard languages that rely on suggestions, such as Chinese, Korean, and Cantonese, so users can only switch between English layouts in that field. Other keyboards only turn off suggestions. This isn't mentioned in the docs today, so it can silently break text input for non-English users.As suggested in #139143 (comment), this PR documents the side effect in the
enableSuggestionstemplate inTextInputConfiguration.TextField,CupertinoTextField,EditableText, andSearchDelegatereuse that template, so their docs are updated too.Fixes #139143
Pre-launch Checklist
///).🤖 Generated with Claude Code