Skip to content

Remove unused Fuchsia sysmem header files - #193244

Merged
mbrase merged 1 commit into
flutter:masterfrom
mbrase:fuchsia_fidl_sysmem
Oct 2, 2026
Merged

mbrase merged 1 commit into
flutter:masterfrom
mbrase:fuchsia_fidl_sysmem

Conversation

@mbrase

@mbrase mbrase commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

The fuchsia/sysmem/cpp/fidl.h header is no longer used by text-input-test.cc or touch-input-test.cc. This is needed to allow an upstream change in Fuchsia.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused include directive for <fuchsia/sysmem/cpp/fidl.h> from both text-input-test.cc and touch-input-test.cc in the Fuchsia platform integration tests. I have no feedback to provide.

@mbrase mbrase added the platform-fuchsia Fuchsia code specifically label Sep 23, 2026
@mbrase mbrase self-assigned this Sep 23, 2026
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. labels Sep 23, 2026

@zijiehe-google-com zijiehe-google-com left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinmc

Copy link
Copy Markdown
Contributor

@mbrase Heads up google tests are failing.

@mbrase
mbrase enabled auto-merge September 24, 2026 20:32
@mbrase
mbrase disabled auto-merge September 29, 2026 05:55
@mbrase
mbrase force-pushed the fuchsia_fidl_sysmem branch 2 times, most recently from 8b5e103 to 7d560b9 Compare October 1, 2026 04:02
@mbrase
mbrase enabled auto-merge October 1, 2026 16:20
The fuchsia/sysmem/cpp/fidl.h header is no longer used by
text-input-test.cc or touch-input-test.cc. This is needed to allow an
upstream change in Fuchsia.
@mbrase
mbrase added this pull request to the merge queue Oct 2, 2026
Merged via the queue into flutter:master with commit d26bc92 Oct 2, 2026
17 of 18 checks passed
@mbrase
mbrase deleted the fuchsia_fidl_sysmem branch October 2, 2026 03:43
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 2, 2026
flutter/flutter@e89fd0a...d03768e

2026-10-02 [email protected] Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694)
2026-10-02 [email protected] [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005)
2026-10-02 [email protected] Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692)
2026-10-02 [email protected] Remove unused Fuchsia sysmem header files (flutter/flutter#193244)
2026-10-02 [email protected] [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968)
2026-10-02 [email protected] [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222)
2026-10-02 [email protected] [Embedder] Support render texture for vulkan (flutter/flutter#188855)
2026-10-02 [email protected] Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429)
2026-10-02 [email protected] Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714)
2026-10-02 [email protected] [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836)
2026-10-02 [email protected] [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963)
2026-10-02 [email protected] [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678)
2026-10-02 [email protected] [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427)
2026-10-02 [email protected] Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676)
2026-10-01 [email protected] Fix analysis failures due to missing `const` (flutter/flutter#193685)
2026-10-01 [email protected] Removes a11y_assessment app (flutter/flutter#193671)
2026-10-01 [email protected] test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529)
2026-10-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193666)
2026-10-01 [email protected] Avoid using relative path in Process.start (flutter/flutter#193664)
2026-10-01 [email protected] [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488)
2026-10-01 [email protected] ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580)
2026-10-01 [email protected] [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591)
2026-10-01 [email protected] [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-fuchsia Fuchsia code specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants