Repository navigation
[flutter_tools] Explicitly track host CPU architecture in command result analytics - #191836
Merged
Merged
Conversation
…ult analytics Passes globals.os.hostPlatform.platformName to Event.flutterCommandResult to explicitly track host architecture across all host operating systems. Upgrades package:unified_analytics to 8.0.18. Fixes flutter#191765
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the unified_analytics dependency to version 8.0.18 and adds the hostArch property, populated with the host platform's name, to the Event.flutterCommandResult telemetry events. Corresponding tests have been updated to reflect this change. There are no review comments, so I have no feedback to provide.
github-actions
Bot
added
the
tool
# Conflicts: # packages/flutter_tools/lib/src/runner/flutter_command_runner.dart # packages/flutter_tools/pubspec.yaml
jmagman
reviewed
Aug 27, 2026
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
The idea is that we would parse the existing operatingSystemVersion to figure out it's Windows from that big long string, for example, and then use this to figure out arch?
Maybe cliName is actually more useful here since it encodes both?
flutter/packages/flutter_tools/lib/src/base/os.dart
Lines 635 to 643 in 53c1746
wdyt?
Passes HostPlatform.cliName (e.g. 'darwin-arm64', 'windows-x64', 'linux-x64') instead of platformName to Event.flutterCommandResult so both OS and architecture are encoded in the analytics event.
…ostUsage Avoids accessing globals.os in FlutterCommand._sendPostUsage, resolving _os via toolContext?.os ?? globals.os instead so hermetic command tests running without ambient AppContext do not throw UnsupportedError.
# Conflicts: # packages/flutter_tools/lib/src/runner/flutter_command.dart
jmagman
approved these changes
Oct 1, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Oct 2, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 2, 2026
flutter/flutter@e89fd0a...d03768e 2026-10-02 [email protected] Roll Skia from 7b7326917e77 to 9e88bf828078 (8 revisions) (flutter/flutter#193694) 2026-10-02 [email protected] [Widget Preview] Provide descriptive error when widget preview is unconstrained (flutter/flutter#193005) 2026-10-02 [email protected] Roll Dart SDK from 0e7642b85457 to ac1a97aae47d (26 revisions) (flutter/flutter#193692) 2026-10-02 [email protected] Remove unused Fuchsia sysmem header files (flutter/flutter#193244) 2026-10-02 [email protected] [Windows] Preserve composing extent in setEditingState (flutter/flutter#189968) 2026-10-02 [email protected] [docs] Make Border.symmetric docs more explicit about their arguments (flutter/flutter#193222) 2026-10-02 [email protected] [Embedder] Support render texture for vulkan (flutter/flutter#188855) 2026-10-02 [email protected] Updated Remaining Engine Defaults to SDK 37 (flutter/flutter#190429) 2026-10-02 [email protected] Document that enableSuggestions: false can disable keyboard languages on Android (flutter/flutter#192714) 2026-10-02 [email protected] [flutter_tools] Explicitly track host CPU architecture in command result analytics (flutter/flutter#191836) 2026-10-02 [email protected] [web] Preserve DOM focus on role update and honor isAccessibilityFocusBlocked (flutter/flutter#192963) 2026-10-02 [email protected] [flutter_tools] Include base href in web hot reload script paths (flutter/flutter#193678) 2026-10-02 [email protected] [Impeller] Deduplicate GLES render pass state (flutter/flutter#193427) 2026-10-02 [email protected] Roll Skia from f2d68e0b8863 to 7b7326917e77 (16 revisions) (flutter/flutter#193676) 2026-10-01 [email protected] Fix analysis failures due to missing `const` (flutter/flutter#193685) 2026-10-01 [email protected] Removes a11y_assessment app (flutter/flutter#193671) 2026-10-01 [email protected] test: configure Xvfb and openbox for windowing_test (flutter/flutter#193529) 2026-10-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193666) 2026-10-01 [email protected] Avoid using relative path in Process.start (flutter/flutter#193664) 2026-10-01 [email protected] [AGP 9.1.0 Migration #6] Deliver Flutter assets as a generated assets source directory on the app path (flutter/flutter#192488) 2026-10-01 [email protected] ci(bringup): android_java17_build_android_host_app_with_module_aar is green (flutter/flutter#193580) 2026-10-01 [email protected] [flutter_tools] Fix Use dependency graph to determine plugin initialization order (flutter/flutter#191591) 2026-10-01 [email protected] [flutter_tools] Migrate DaemonCommand and Daemon domains to constructor DI (flutter/flutter#193542) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
package:unified_analyticsto8.0.18and passesglobals.os.hostPlatform.platformNametoEvent.flutterCommandResultto explicitly track host architecture across all host operating systems.Fixes #191765
Pre-launch Checklist
///).