Skip to content

Add SliverAppBar showOnScreen semantics test coverage - #190410

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
Vi-debug:test-sliver-app-bar-show-on-screen-semantics
Aug 27, 2026
Merged

Add SliverAppBar showOnScreen semantics test coverage#190410
auto-submit[bot] merged 2 commits into
flutter:masterfrom
Vi-debug:test-sliver-app-bar-show-on-screen-semantics

Conversation

@Vi-debug

@Vi-debug Vi-debug commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

In #186611 the widgets test showOnScreen works with pinned app bar and sliver list was switched from SliverAppBar to a private SliverPersistentHeader delegate, as part of removing the material import from scrollable_semantics_test.dart. That was the only test exercising SemanticsAction.showOnScreen against a pinned SliverAppBar, so the Material path lost coverage and a TODO was left behind to track restoring it.

This PR restores the coverage by adding an equivalent test to packages/flutter/test/material/app_bar_sliver_test.dart, which already imports ../widgets/semantics_tester.dart and is where the other SliverAppBar semantics tests live. The test performs SemanticsAction.showOnScreen on the first list item and asserts it is revealed below the pinned app bar (dy == expandedHeight) rather than underneath it.

I also removed the TODO in packages/flutter/test/widgets/scrollable_semantics_test.dart, since it points at the issue this PR fixes. Note that the TODO says "in material_ui package" — that package does not exist in the repo yet, so the test is placed in the existing Material test suite (which matches the issue description) and will move along with app_bar_sliver_test.dart when the decoupling work lands. Happy to keep the TODO instead if you'd prefer to track the material_ui move separately.

Verification:

  • flutter test packages/flutter/test/material/app_bar_sliver_test.dart — 53 tests pass.
  • flutter test packages/flutter/test/widgets/scrollable_semantics_test.dart — 20 tests pass.
  • To confirm the assertion is load-bearing, flipping pinned to false fails the new test with Expected: <56.0> Actual: <6.0>.

Fixes #189117

Pre-launch Checklist

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Aug 2, 2026
@google-cla

google-cla Bot commented Aug 2, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Vi-debug
Vi-debug marked this pull request as ready for review August 2, 2026 16:13
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test verifying that showOnScreen works with a pinned SliverAppBar and a sliver list, and removes a related TODO comment from the scrollable semantics tests. Feedback suggests improving the new test by ensuring robust resource cleanup with addTearDown for the semantics tester, simplifying the widget tree structure using MaterialApp and CustomScrollView, and renaming local constants to follow the lowerCamelCase style guide convention.

Comment thread packages/flutter/test/material/app_bar_sliver_test.dart Outdated
Comment on lines +2006 to +2071
testWidgets('showOnScreen works with pinned SliverAppBar and sliver list', (
WidgetTester tester,
) async {
final semantics = SemanticsTester(tester); // enables semantics tree generation

const kItemHeight = 100.0;
const kExpandedAppBarHeight = 56.0;

final containers = List<Widget>.generate(
80,
(int i) => MergeSemantics(
child: SizedBox(height: kItemHeight, child: Text('container $i')),
),
);

final scrollController = ScrollController(initialScrollOffset: kItemHeight / 2);
addTearDown(scrollController.dispose);

await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: Localizations(
locale: const Locale('en', 'us'),
delegates: const <LocalizationsDelegate<dynamic>>[
DefaultWidgetsLocalizations.delegate,
DefaultMaterialLocalizations.delegate,
],
child: MediaQuery(
data: const MediaQueryData(),
child: Scrollable(
controller: scrollController,
viewportBuilder: (BuildContext context, ViewportOffset offset) {
return Viewport(
offset: offset,
slivers: <Widget>[
const SliverAppBar(
pinned: true,
expandedHeight: kExpandedAppBarHeight,
flexibleSpace: FlexibleSpaceBar(title: Text('App Bar')),
),
SliverList.list(children: containers),
],
);
},
),
),
),
),
);

expect(scrollController.offset, kItemHeight / 2);

final int firstContainerId = tester
.renderObject(find.byWidget(containers.first))
.debugSemantics!
.id;
tester.binding.pipelineOwner.semanticsOwner!.performAction(
firstContainerId,
SemanticsAction.showOnScreen,
);
await tester.pump();
await tester.pump(const Duration(seconds: 5));
expect(tester.getTopLeft(find.byWidget(containers.first)).dy, kExpandedAppBarHeight);

semantics.dispose();
});

@gemini-code-assist gemini-code-assist Bot Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This test can be simplified and made more robust:

  1. Robust Resource Cleanup: Use addTearDown(semantics.dispose) immediately after creating SemanticsTester. This ensures that the semantics tester is properly disposed of even if an assertion fails during the test, preventing state leakage to subsequent tests.
  2. Simplify Widget Tree: Instead of manually nesting Directionality, Localizations, MediaQuery, Scrollable, and Viewport, use MaterialApp and CustomScrollView. This is much cleaner, more readable, and matches how these widgets are typically used in real applications.
  3. Style Guide Adherence: Local constants should use lowerCamelCase (e.g., itemHeight and expandedAppBarHeight) rather than kCamelCase per Effective Dart: Style.
  testWidgets('showOnScreen works with pinned SliverAppBar and sliver list', (
    WidgetTester tester,
  ) async {
    final SemanticsTester semantics = SemanticsTester(tester);
    addTearDown(semantics.dispose);

    const double itemHeight = 100.0;
    const double expandedAppBarHeight = 56.0;

    final List<Widget> containers = List<Widget>.generate(
      80,
      (int i) => MergeSemantics(
        child: SizedBox(height: itemHeight, child: Text('container $i')),
      ),
    );

    final ScrollController scrollController = ScrollController(initialScrollOffset: itemHeight / 2);
    addTearDown(scrollController.dispose);

    await tester.pumpWidget(
      MaterialApp(
        home: CustomScrollView(
          controller: scrollController,
          slivers: <Widget>[
            const SliverAppBar(
              pinned: true,
              expandedHeight: expandedAppBarHeight,
              flexibleSpace: FlexibleSpaceBar(title: Text('App Bar')),
            ),
            SliverList.list(children: containers),
          ],
        ),
      ),
    );

    expect(scrollController.offset, itemHeight / 2);

    final int firstContainerId = tester
        .renderObject(find.byWidget(containers.first))
        .debugSemantics!
        .id;
    tester.binding.pipelineOwner.semanticsOwner!.performAction(
      firstContainerId,
      SemanticsAction.showOnScreen,
    );
    await tester.pump();
    await tester.pump(const Duration(seconds: 5));
    expect(tester.getTopLeft(find.byWidget(containers.first)).dy, expandedAppBarHeight);
  });
References
  1. Effective Dart: Style recommends using lowerCamelCase for constant names, including local constants. (link)

@Vi-debug
Vi-debug force-pushed the test-sliver-app-bar-show-on-screen-semantics branch from f645378 to 7ff110d Compare August 2, 2026 16:17
@Vi-debug

Vi-debug commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Closing this in favour of flutter/packages#12341.

This PR adds a test under packages/flutter/test/material/, which trips the Check Code Freeze job — Material and Cupertino are frozen here per #184093, and that policy says in-flight Material/Cupertino PRs should be closed and ported to the new packages once they ship. The original TODO also pointed at material_ui specifically, so flutter/packages is the correct home.

The equivalent test now lives in packages/material_ui/test/app_bar_sliver_test.dart in flutter/packages#12341.

One leftover: this PR also removed the TODO(rkishan516) in packages/flutter/test/widgets/scrollable_semantics_test.dart. That file isn't frozen, but the TODO shouldn't be removed until the material_ui coverage actually lands, so I'll open a small follow-up here once flutter/packages#12341 merges. Issue #189117 will also need closing by hand, since cross-repo Fixes keywords don't auto-close.

@Vi-debug Vi-debug closed this Aug 2, 2026
@Vi-debug Vi-debug mentioned this pull request Aug 2, 2026
Closed
@Piinks Piinks reopened this Aug 3, 2026
@fluttergithubbot

fluttergithubbot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

An existing Git SHA, 7ff110d90a810af655ef81b2efbd39f29e0b3a14, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@Piinks

Piinks commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Re-opened to keep of track of for when contributions open in material_ui.

@Piinks Piinks added waiting for code freeze This PR is waiting for a code freeze to resolve. Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. labels Aug 3, 2026
Piinks
Piinks reviewed Aug 7, 2026
View reviewed changes
Comment thread packages/flutter/test/material/app_bar_sliver_test.dart Outdated
semantics.dispose();
});

testWidgets('showOnScreen works with pinned SliverAppBar and sliver list', (

@Piinks Piinks Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-opened this, but when this PR does move forward, it will not be adding a test here, but in material_ui.
We'll be able o re-open that other PR soon :)

@dkwingsmt

dkwingsmt commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR is ready to port to flutter/packages! 🥳
See guidance and instructions in #188444
Can you change this PR to only include the framework test, and open a new PR in flutter/packages to add the test for material_ui? Thank you!

@dkwingsmt dkwingsmt added Decoupling: Port to flutter/packages This PR is ready to be ported to flutter/packages. We will provide instructions to do so. Decoupling: Split PR The PR will need to be split to separate Material & Cupertino changes and removed Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. labels Aug 25, 2026
@github-actions github-actions Bot removed the p: material_ui material_ui package in flutter/packages label Aug 26, 2026
@Vi-debug Vi-debug mentioned this pull request Aug 26, 2026
Draft
@Vi-debug

Vi-debug commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Done. Trimmed this PR to the framework-only TODO removal, and opened the material_ui test as flutter/packages#12631
@Piinks @dkwingsmt

Piinks
Piinks approved these changes Aug 26, 2026
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added CICD Run CI/CD and removed Decoupling: Port to flutter/packages This PR is ready to be ported to flutter/packages. We will provide instructions to do so. Decoupling: Split PR The PR will need to be split to separate Material & Cupertino changes labels Aug 26, 2026
@Piinks Piinks removed the waiting for code freeze This PR is waiting for a code freeze to resolve. label Aug 26, 2026
@Vi-debug @Piinks
Add SliverAppBar showOnScreen semantics test coverage
e40bc54 
The widgets test 'showOnScreen works with pinned app bar and sliver list'
was switched from SliverAppBar to a SliverPersistentHeader delegate in
flutter#186611, which left the Material SliverAppBar path without coverage for
SemanticsAction.showOnScreen.

Restore that coverage in app_bar_sliver_test.dart and drop the TODO that
tracked it.

Fixes flutter#189117
@Vi-debug @Piinks
Drop material_ui test coverage; ported separately to flutter/packages
cbc183a 
Per flutter#188444, restore the SliverAppBar test in
flutter/packages instead, since Material is frozen here. This PR now
only carries the framework-side TODO removal.
@Piinks
Piinks force-pushed the test-sliver-app-bar-show-on-screen-semantics branch from 2ee2a7b to cbc183a Compare August 26, 2026 19:54
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 26, 2026
@Piinks Piinks added the CICD Run CI/CD label Aug 26, 2026
dkwingsmt
dkwingsmt approved these changes Aug 26, 2026
View reviewed changes

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit

auto-submit Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/190410, Failed to enqueue flutter/flutter/190410 with HTTP 400: Pull request Required status check "Check Code Freeze" is queued..

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 26, 2026
Merged via the queue into flutter:master with commit edd4547 Aug 27, 2026
36 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2026
This was referenced Aug 27, 2026
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 28, 2026
@engine-flutter-autoroll
Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions) (#12660)
0bab416 
Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions)

flutter/flutter@15d8908...e8dca90

2026-08-27 [email protected] Terminate existing process before launching with devicectl (flutter/flutter#191885)
2026-08-27 [email protected] Roll Fuchsia Linux SDK from qjOQi-zAgu_tADorh... to dDxH8G5cDBP602eyG... (flutter/flutter#191889)
2026-08-27 [email protected] [flutter_tools] Verify native assets tree-shaking during linking (flutter/flutter#191637)
2026-08-27 [email protected] Denylists b-series powervr from vulkan (flutter/flutter#191808)
2026-08-27 [email protected] Handle linear and radial gradients in UberSDF (flutter/flutter#190874)
2026-08-27 [email protected] Roll Packages from 740f093 to bd3cbc1 (7 revisions) (flutter/flutter#191886)
2026-08-27 [email protected] Disable more Windows tests that have been causing CI flakes (flutter/flutter#191822)
2026-08-27 [email protected] Roll Skia from d32721369bd8 to 82e972ea84b1 (2 revisions) (flutter/flutter#191880)
2026-08-27 [email protected] Roll Skia from 3640b8edd16c to d32721369bd8 (10 revisions) (flutter/flutter#191858)
2026-08-27 [email protected] Revert: [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191863)
2026-08-27 [email protected] Roll Fuchsia Test Scripts from 0iCv10IlKfiilEBOU... to 6SXRz6wsA2Zm_rAqP... (flutter/flutter#191852)
2026-08-27 [email protected] Roll pub packages (flutter/flutter#191851)
2026-08-27 [email protected] Refactor FormField build wrappers (flutter/flutter#185795)
2026-08-27 [email protected] Make ScrollPhysics reactive by introducing shouldUpdate (flutter/flutter#189664)
2026-08-27 [email protected] macOS: Fix crash on out-of-bounds text input ranges (flutter/flutter#191780)
2026-08-27 [email protected] Add HCPP feature flag, and turn it on by default in beta/master (flutter/flutter#190623)
2026-08-27 [email protected] [tool] Migrate CleanCommand to modular dependency injection (flutter/flutter#190742)
2026-08-26 [email protected] Update triage docs for ecosystem and codelab changes (flutter/flutter#191809)
2026-08-26 [email protected] [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191824)
2026-08-26 [email protected] [UIScene] Migrate dev/benchmarks/complex_layout to UIScene lifecycle (flutter/flutter#191619)
2026-08-26 [email protected] Add SliverAppBar showOnScreen semantics test coverage (flutter/flutter#190410)
2026-08-26 [email protected] Add prompt_suggestion icon to list of RTL mirroring icons. (flutter/flutter#191741)
2026-08-26 [email protected] Remove bringup for batch 3 (flutter/flutter#191750)
2026-08-26 [email protected] Roll Skia from b5465d7b0b77 to 3640b8edd16c (6 revisions) (flutter/flutter#191835)
2026-08-26 [email protected] Uiscene migrate custom channels views (flutter/flutter#191817)
2026-08-26 [email protected] Support --[no-]adb-log-filtering CLI option (flutter/flutter#187252)
2026-08-26 [email protected] Roll Dart SDK from cb8a4e1a0fbb to cb4c39d067f3 (2 revisions) (flutter/flutter#191825)
2026-08-26 [email protected] Fix `Navigator.pushNamed<T>()` type checking (flutter/flutter#188148)
2026-08-26 [email protected] Handle the case where a window doesn't have a title set (flutter/flutter#191767)
2026-08-26 [email protected] [Android] Remove old `InputType` constructor from embedding (flutter/flutter#191244)
2026-08-26 [email protected] Roll Skia from 244a6a0f8f92 to b5465d7b0b77 (19 revisions) (flutter/flutter#191810)
2026-08-26 [email protected] Tolerate floating-point rounding in paintImage centerSlice assertion (flutter/flutter#185789)
2026-08-26 [email protected] Fixes translated bounded blurs (flutter/flutter#191615)
2026-08-26 [email protected] Roll Fuchsia Linux SDK from MstTWE1RDOT-RnrtH... to qjOQi-zAgu_tADorh... (flutter/flutter#191769)
2026-08-26 [email protected] Lerp HSVColor and HSLColor hue along the shortest arc (flutter/flutter#191186)
2026-08-26 [email protected] Fix enum instances comparison to use `equality ==` since dart has the correct behavior now (flutter/flutter#191537)
2026-08-26 [email protected] Switches windows to opengles 3 (flutter/flutter#191516)
2026-08-26 [email protected] Roll Dart SDK from 7739e8602bc1 to cb8a4e1a0fbb (1 revision) (flutter/flutter#191784)
2026-08-26 [email protected] iOS,macOS: Check viewType before creating a platform view (flutter/flutter#191777)
2026-08-26 [email protected] Revert: [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191793)
2026-08-26 [email protected] refactor(flutter_tools): clean up dead unreferenced declarations (flutter/flutter#191163)
2026-08-26 [email protected] Roll Fuchsia GN SDK from a87CbQSWEjkPUK1ZY... to ZsxUUK2SfA-TrNvb8... (flutter/flutter#191763)
2026-08-26 [email protected] [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191732)
2026-08-25 [email protected] Remove legacy gen_defaults analyze checks (flutter/flutter#191629)
2026-08-25 [email protected] Refactors `try` to avoid `unawaited_return_in_try_block` case (flutter/flutter#191129)
2026-08-25 [email protected] Roll Dart SDK from 8996935d3d0a to 7739e8602bc1 (1 revision) (flutter/flutter#191754)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions) (flutte…
a4509c8 
…r#12660)

Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions)

flutter/flutter@15d8908...e8dca90

2026-08-27 [email protected] Terminate existing process before launching with devicectl (flutter/flutter#191885)
2026-08-27 [email protected] Roll Fuchsia Linux SDK from qjOQi-zAgu_tADorh... to dDxH8G5cDBP602eyG... (flutter/flutter#191889)
2026-08-27 [email protected] [flutter_tools] Verify native assets tree-shaking during linking (flutter/flutter#191637)
2026-08-27 [email protected] Denylists b-series powervr from vulkan (flutter/flutter#191808)
2026-08-27 [email protected] Handle linear and radial gradients in UberSDF (flutter/flutter#190874)
2026-08-27 [email protected] Roll Packages from 740f093 to bd3cbc1 (7 revisions) (flutter/flutter#191886)
2026-08-27 [email protected] Disable more Windows tests that have been causing CI flakes (flutter/flutter#191822)
2026-08-27 [email protected] Roll Skia from d32721369bd8 to 82e972ea84b1 (2 revisions) (flutter/flutter#191880)
2026-08-27 [email protected] Roll Skia from 3640b8edd16c to d32721369bd8 (10 revisions) (flutter/flutter#191858)
2026-08-27 [email protected] Revert: [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191863)
2026-08-27 [email protected] Roll Fuchsia Test Scripts from 0iCv10IlKfiilEBOU... to 6SXRz6wsA2Zm_rAqP... (flutter/flutter#191852)
2026-08-27 [email protected] Roll pub packages (flutter/flutter#191851)
2026-08-27 [email protected] Refactor FormField build wrappers (flutter/flutter#185795)
2026-08-27 [email protected] Make ScrollPhysics reactive by introducing shouldUpdate (flutter/flutter#189664)
2026-08-27 [email protected] macOS: Fix crash on out-of-bounds text input ranges (flutter/flutter#191780)
2026-08-27 [email protected] Add HCPP feature flag, and turn it on by default in beta/master (flutter/flutter#190623)
2026-08-27 [email protected] [tool] Migrate CleanCommand to modular dependency injection (flutter/flutter#190742)
2026-08-26 [email protected] Update triage docs for ecosystem and codelab changes (flutter/flutter#191809)
2026-08-26 [email protected] [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191824)
2026-08-26 [email protected] [UIScene] Migrate dev/benchmarks/complex_layout to UIScene lifecycle (flutter/flutter#191619)
2026-08-26 [email protected] Add SliverAppBar showOnScreen semantics test coverage (flutter/flutter#190410)
2026-08-26 [email protected] Add prompt_suggestion icon to list of RTL mirroring icons. (flutter/flutter#191741)
2026-08-26 [email protected] Remove bringup for batch 3 (flutter/flutter#191750)
2026-08-26 [email protected] Roll Skia from b5465d7b0b77 to 3640b8edd16c (6 revisions) (flutter/flutter#191835)
2026-08-26 [email protected] Uiscene migrate custom channels views (flutter/flutter#191817)
2026-08-26 [email protected] Support --[no-]adb-log-filtering CLI option (flutter/flutter#187252)
2026-08-26 [email protected] Roll Dart SDK from cb8a4e1a0fbb to cb4c39d067f3 (2 revisions) (flutter/flutter#191825)
2026-08-26 [email protected] Fix `Navigator.pushNamed<T>()` type checking (flutter/flutter#188148)
2026-08-26 [email protected] Handle the case where a window doesn't have a title set (flutter/flutter#191767)
2026-08-26 [email protected] [Android] Remove old `InputType` constructor from embedding (flutter/flutter#191244)
2026-08-26 [email protected] Roll Skia from 244a6a0f8f92 to b5465d7b0b77 (19 revisions) (flutter/flutter#191810)
2026-08-26 [email protected] Tolerate floating-point rounding in paintImage centerSlice assertion (flutter/flutter#185789)
2026-08-26 [email protected] Fixes translated bounded blurs (flutter/flutter#191615)
2026-08-26 [email protected] Roll Fuchsia Linux SDK from MstTWE1RDOT-RnrtH... to qjOQi-zAgu_tADorh... (flutter/flutter#191769)
2026-08-26 [email protected] Lerp HSVColor and HSLColor hue along the shortest arc (flutter/flutter#191186)
2026-08-26 [email protected] Fix enum instances comparison to use `equality ==` since dart has the correct behavior now (flutter/flutter#191537)
2026-08-26 [email protected] Switches windows to opengles 3 (flutter/flutter#191516)
2026-08-26 [email protected] Roll Dart SDK from 7739e8602bc1 to cb8a4e1a0fbb (1 revision) (flutter/flutter#191784)
2026-08-26 [email protected] iOS,macOS: Check viewType before creating a platform view (flutter/flutter#191777)
2026-08-26 [email protected] Revert: [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191793)
2026-08-26 [email protected] refactor(flutter_tools): clean up dead unreferenced declarations (flutter/flutter#191163)
2026-08-26 [email protected] Roll Fuchsia GN SDK from a87CbQSWEjkPUK1ZY... to ZsxUUK2SfA-TrNvb8... (flutter/flutter#191763)
2026-08-26 [email protected] [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191732)
2026-08-25 [email protected] Remove legacy gen_defaults analyze checks (flutter/flutter#191629)
2026-08-25 [email protected] Refactors `try` to avoid `unawaited_return_in_try_block` case (flutter/flutter#191129)
2026-08-25 [email protected] Roll Dart SDK from 8996935d3d0a to 7739e8602bc1 (1 revision) (flutter/flutter#191754)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions) (flutte…
675e8a4 
…r#12660)

Roll Flutter from 15d8908addf6 to e8dca90ec9e0 (58 revisions)

flutter/flutter@15d8908...e8dca90

2026-08-27 [email protected] Terminate existing process before launching with devicectl (flutter/flutter#191885)
2026-08-27 [email protected] Roll Fuchsia Linux SDK from qjOQi-zAgu_tADorh... to dDxH8G5cDBP602eyG... (flutter/flutter#191889)
2026-08-27 [email protected] [flutter_tools] Verify native assets tree-shaking during linking (flutter/flutter#191637)
2026-08-27 [email protected] Denylists b-series powervr from vulkan (flutter/flutter#191808)
2026-08-27 [email protected] Handle linear and radial gradients in UberSDF (flutter/flutter#190874)
2026-08-27 [email protected] Roll Packages from 740f093 to bd3cbc1 (7 revisions) (flutter/flutter#191886)
2026-08-27 [email protected] Disable more Windows tests that have been causing CI flakes (flutter/flutter#191822)
2026-08-27 [email protected] Roll Skia from d32721369bd8 to 82e972ea84b1 (2 revisions) (flutter/flutter#191880)
2026-08-27 [email protected] Roll Skia from 3640b8edd16c to d32721369bd8 (10 revisions) (flutter/flutter#191858)
2026-08-27 [email protected] Revert: [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191863)
2026-08-27 [email protected] Roll Fuchsia Test Scripts from 0iCv10IlKfiilEBOU... to 6SXRz6wsA2Zm_rAqP... (flutter/flutter#191852)
2026-08-27 [email protected] Roll pub packages (flutter/flutter#191851)
2026-08-27 [email protected] Refactor FormField build wrappers (flutter/flutter#185795)
2026-08-27 [email protected] Make ScrollPhysics reactive by introducing shouldUpdate (flutter/flutter#189664)
2026-08-27 [email protected] macOS: Fix crash on out-of-bounds text input ranges (flutter/flutter#191780)
2026-08-27 [email protected] Add HCPP feature flag, and turn it on by default in beta/master (flutter/flutter#190623)
2026-08-27 [email protected] [tool] Migrate CleanCommand to modular dependency injection (flutter/flutter#190742)
2026-08-26 [email protected] Update triage docs for ecosystem and codelab changes (flutter/flutter#191809)
2026-08-26 [email protected] [AGP 9] Update remaining tests to AGP 9 (flutter/flutter#191824)
2026-08-26 [email protected] [UIScene] Migrate dev/benchmarks/complex_layout to UIScene lifecycle (flutter/flutter#191619)
2026-08-26 [email protected] Add SliverAppBar showOnScreen semantics test coverage (flutter/flutter#190410)
2026-08-26 [email protected] Add prompt_suggestion icon to list of RTL mirroring icons. (flutter/flutter#191741)
2026-08-26 [email protected] Remove bringup for batch 3 (flutter/flutter#191750)
2026-08-26 [email protected] Roll Skia from b5465d7b0b77 to 3640b8edd16c (6 revisions) (flutter/flutter#191835)
2026-08-26 [email protected] Uiscene migrate custom channels views (flutter/flutter#191817)
2026-08-26 [email protected] Support --[no-]adb-log-filtering CLI option (flutter/flutter#187252)
2026-08-26 [email protected] Roll Dart SDK from cb8a4e1a0fbb to cb4c39d067f3 (2 revisions) (flutter/flutter#191825)
2026-08-26 [email protected] Fix `Navigator.pushNamed<T>()` type checking (flutter/flutter#188148)
2026-08-26 [email protected] Handle the case where a window doesn't have a title set (flutter/flutter#191767)
2026-08-26 [email protected] [Android] Remove old `InputType` constructor from embedding (flutter/flutter#191244)
2026-08-26 [email protected] Roll Skia from 244a6a0f8f92 to b5465d7b0b77 (19 revisions) (flutter/flutter#191810)
2026-08-26 [email protected] Tolerate floating-point rounding in paintImage centerSlice assertion (flutter/flutter#185789)
2026-08-26 [email protected] Fixes translated bounded blurs (flutter/flutter#191615)
2026-08-26 [email protected] Roll Fuchsia Linux SDK from MstTWE1RDOT-RnrtH... to qjOQi-zAgu_tADorh... (flutter/flutter#191769)
2026-08-26 [email protected] Lerp HSVColor and HSLColor hue along the shortest arc (flutter/flutter#191186)
2026-08-26 [email protected] Fix enum instances comparison to use `equality ==` since dart has the correct behavior now (flutter/flutter#191537)
2026-08-26 [email protected] Switches windows to opengles 3 (flutter/flutter#191516)
2026-08-26 [email protected] Roll Dart SDK from 7739e8602bc1 to cb8a4e1a0fbb (1 revision) (flutter/flutter#191784)
2026-08-26 [email protected] iOS,macOS: Check viewType before creating a platform view (flutter/flutter#191777)
2026-08-26 [email protected] Revert: [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191793)
2026-08-26 [email protected] refactor(flutter_tools): clean up dead unreferenced declarations (flutter/flutter#191163)
2026-08-26 [email protected] Roll Fuchsia GN SDK from a87CbQSWEjkPUK1ZY... to ZsxUUK2SfA-TrNvb8... (flutter/flutter#191763)
2026-08-26 [email protected] [tool_tests] Remove bringup from Windows tool_tests_commands_2_2 (flutter/flutter#191732)
2026-08-25 [email protected] Remove legacy gen_defaults analyze checks (flutter/flutter#191629)
2026-08-25 [email protected] Refactors `try` to avoid `unawaited_return_in_try_block` case (flutter/flutter#191129)
2026-08-25 [email protected] Roll Dart SDK from 8996935d3d0a to 7739e8602bc1 (1 revision) (flutter/flutter#191754)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes
@Piinks Piinks Piinks approved these changes
@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) CICD Run CI/CD f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SliverAppBar test coverage for showOnScreen semantics

4 participants

@Vi-debug @fluttergithubbot @Piinks @dkwingsmt