Repository navigation
Don't rebuild routes on the second animation frame - #5097
Merged
Merged
Conversation
Contributor
Author
Previously we would rebuild every route on the second animation frame to rejigger the offstage bit and the animations. Now we build the page once and update the offstage bit in place and update the animations using ProxyAnimations.
Contributor
|
|
aam
added a commit
to aam/flutter
that referenced
this pull request
Apr 26, 2018
Changes since the last roll: ``` e11905c Add tooltip method to Android AccessibilityBridge (flutter#5103) 2ee36e2 Always enable verbose logging on fuchsia. (flutter#5104) 131349f Update flutter runner process name to reflect last running shell. (flutter#5102) ad9826c Roll src/third_party/skia/ c79e2d155..47ed6f10e (10 commits; 1 trivial rolls) (flutter#5100) 7617d28 libtxt: post-process glyph positions in order to accurately right-justify text (flutter#5093) 895c965 Set file modified callback. (flutter#5096) 956f3ee Roll src/third_party/skia/ 5c9369eb1..c79e2d155 (7 commits) (flutter#5099) 6e51122 Roll src/third_party/skia/ 643ab1bf5..5c9369eb1 (1 commit; 1 trivial rolls) (flutter#5098) a9180ca Roll src/third_party/skia/ 6b043cb9c..643ab1bf5 (3 commits; 3 trivial rolls) (flutter#5097) 82d4610 Roll src/third_party/skia/ 1366282bc..6b043cb9c (2 commits) (flutter#5095) fb4926e Roll src/third_party/skia/ 580aee2fa..1366282bc (2 commits) (flutter#5094) c249b70 Path metrics/getBounds/combinations again (flutter#4957) df255b8 Roll src/third_party/skia/ de5cffbc4..580aee2fa (16 commits) (flutter#5092) e44e1b4 Initial plugin support for background downloads + content fetching (flutter#5082) 78f8a0f [fuchsia] Changes for running Dart 2 on flutter_runner. (flutter#5080) cbec56a Roll src/third_party/skia/ 77e95f706..de5cffbc4 (14 commits) (flutter#5090) 8da9398 Throw an exception if a secondary isolate tries to send a platform message (flutter#5069) ```
aam
added a commit
that referenced
this pull request
Apr 27, 2018
Changes since the last roll: ``` e11905c Add tooltip method to Android AccessibilityBridge (#5103) 2ee36e2 Always enable verbose logging on fuchsia. (#5104) 131349f Update flutter runner process name to reflect last running shell. (#5102) ad9826c Roll src/third_party/skia/ c79e2d155..47ed6f10e (10 commits; 1 trivial rolls) (#5100) 7617d28 libtxt: post-process glyph positions in order to accurately right-justify text (#5093) 895c965 Set file modified callback. (#5096) 956f3ee Roll src/third_party/skia/ 5c9369eb1..c79e2d155 (7 commits) (#5099) 6e51122 Roll src/third_party/skia/ 643ab1bf5..5c9369eb1 (1 commit; 1 trivial rolls) (#5098) a9180ca Roll src/third_party/skia/ 6b043cb9c..643ab1bf5 (3 commits; 3 trivial rolls) (#5097) 82d4610 Roll src/third_party/skia/ 1366282bc..6b043cb9c (2 commits) (#5095) fb4926e Roll src/third_party/skia/ 580aee2fa..1366282bc (2 commits) (#5094) c249b70 Path metrics/getBounds/combinations again (#4957) df255b8 Roll src/third_party/skia/ de5cffbc4..580aee2fa (16 commits) (#5092) e44e1b4 Initial plugin support for background downloads + content fetching (#5082) 78f8a0f [fuchsia] Changes for running Dart 2 on flutter_runner. (#5080) cbec56a Roll src/third_party/skia/ 77e95f706..de5cffbc4 (14 commits) (#5090) 8da9398 Throw an exception if a secondary isolate tries to send a platform message (#5069) ```
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Changes since the last roll: ``` e11905c Add tooltip method to Android AccessibilityBridge (flutter#5103) 2ee36e2 Always enable verbose logging on fuchsia. (flutter#5104) 131349f Update flutter runner process name to reflect last running shell. (flutter#5102) ad9826c Roll src/third_party/skia/ c79e2d155..47ed6f10e (10 commits; 1 trivial rolls) (flutter#5100) 7617d28 libtxt: post-process glyph positions in order to accurately right-justify text (flutter#5093) 895c965 Set file modified callback. (flutter#5096) 956f3ee Roll src/third_party/skia/ 5c9369eb1..c79e2d155 (7 commits) (flutter#5099) 6e51122 Roll src/third_party/skia/ 643ab1bf5..5c9369eb1 (1 commit; 1 trivial rolls) (flutter#5098) a9180ca Roll src/third_party/skia/ 6b043cb9c..643ab1bf5 (3 commits; 3 trivial rolls) (flutter#5097) 82d4610 Roll src/third_party/skia/ 1366282bc..6b043cb9c (2 commits) (flutter#5095) fb4926e Roll src/third_party/skia/ 580aee2fa..1366282bc (2 commits) (flutter#5094) c249b70 Path metrics/getBounds/combinations again (flutter#4957) df255b8 Roll src/third_party/skia/ de5cffbc4..580aee2fa (16 commits) (flutter#5092) e44e1b4 Initial plugin support for background downloads + content fetching (flutter#5082) 78f8a0f [fuchsia] Changes for running Dart 2 on flutter_runner. (flutter#5080) cbec56a Roll src/third_party/skia/ 77e95f706..de5cffbc4 (14 commits) (flutter#5090) 8da9398 Throw an exception if a secondary isolate tries to send a platform message (flutter#5069) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would rebuild every route on the second animation frame to
rejigger the offstage bit and the animations. Now we build the page once and
update the offstage bit in place and update the animations using
ProxyAnimations.