Repository navigation
[google_maps_flutter_platform_interface] Fix PinConfig code sample - #12259
Merged
auto-submit[bot] merged 1 commit intoAug 19, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the google_maps_flutter_platform_interface package to version 2.16.1. The changes correct the PinConfig code sample in the BitmapDescriptor documentation by adding the await keyword to the asynchronous BitmapDescriptor.asset call and adjusting the formatting. There are no review comments, and I have no feedback to provide.
stuartmorgan-g
self-requested a review
July 21, 2026 18:15
stuartmorgan-g
approved these changes
Jul 28, 2026
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
(Unfortunately we don't have an excerpting system for doc comments in this repo like we do for READMEs)
Collaborator
|
@bparrishMines for secondary review |
bparrishMines
added
the
autosubmit
pull Bot
pushed a commit
to Superoldman96/flutter
that referenced
this pull request
Aug 20, 2026
…r#191420) flutter/packages@fdd7d39...1785501 2026-08-20 [email protected] [material_ui] Cleans up shader files and exposes ink_splash shader (flutter/packages#12421) 2026-08-19 [email protected] [material_ui] Fixes typo in code and tests (flutter/packages#12503) 2026-08-19 [email protected] [pigeon] Fixes lint error from unused codec (flutter/packages#12512) 2026-08-19 [email protected] [camera_android_camerax] Add explicit concurrent-futures dependency (flutter/packages#12373) 2026-08-19 [email protected] [go_router] migrates to material_ui and cupertino_ui (flutter/packages#12504) 2026-08-19 [email protected] [animations] Migrate to material_ui (flutter/packages#12467) 2026-08-19 [email protected] [material_ui] Add Material tokens (version 38.2.50) (flutter/packages#12471) 2026-08-19 [email protected] Add `triage-design` label (flutter/packages#12488) 2026-08-19 [email protected] [google_maps_flutter_platform_interface] Fix PinConfig code sample (flutter/packages#12259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second
PinConfigsample in theBitmapDescriptordocs (bitmap.dart:1009) doesn't compile, for two reasons:PinConfig(,BitmapGlyph(andBitmapDescriptor.asset(but only closes two of them. (The siblingTextGlyphsample directly above closes correctly.)await—BitmapDescriptor.assetis declaredstatic Future<AssetMapBitmap> asset(...)(line 278), whileBitmapGlyph.bitmapisfinal BitmapDescriptor bitmap;(line 1106), so a bareBitmapDescriptor.asset(...)can't be assigned to it.The repo's own examples use the awaited form — e.g.
google_maps_flutter_web/example/latest/integration_test/advanced_markers_test.dart:422:The sample now mirrors that. Paren balance goes from 5 open / 4 close to 5 / 5.
Doc comment only; bumped to 2.16.1 with a CHANGELOG entry per the versioning policy — happy to switch to
## NEXTif that's preferred for a docs-only change.Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.