Repository navigation
[animations] Migrate to material_ui - #12467
Conversation
github-actions
Bot
added
p: animations
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the animations package, its examples, and tests to use an external material_ui package instead of Flutter's standard material library, bumping the package version to 3.0.0. Feedback indicates that as a core Flutter package, animations must rely on the built-in material library, and the external dependency and import changes should be reverted.
| required this.transitionDuration, | ||
| required this.reverseTransitionDuration, | ||
| required _ModalTransitionBuilder transitionBuilder, | ||
| required this._transitionBuilder, |
There was a problem hiding this comment.
This change due to newly firing prefer_initializing_formals with Dart 3.12
There was a problem hiding this comment.
Nice, I have been loving migrating these whenever I see them.
|
CI was a timeout, re-running |
526e55a to
1b484a8
Compare
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Did you use the dart fix and if so did it work correctly?
| repository: https://github.com/flutter/packages/tree/main/packages/animations | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+animations%22 | ||
| version: 2.2.0 | ||
| version: 3.0.0 |
There was a problem hiding this comment.
Major bump makes sense to me for this change 👍
| sdk: ^3.12.0 | ||
| flutter: ">=3.44.0" |
There was a problem hiding this comment.
Good call upgrading these to the latest too.
| required this.transitionDuration, | ||
| required this.reverseTransitionDuration, | ||
| required _ModalTransitionBuilder transitionBuilder, | ||
| required this._transitionBuilder, |
There was a problem hiding this comment.
Nice, I have been loving migrating these whenever I see them.
I did! It worked great. Changing the min sdk was something I had to do myself though. Not a big lift by any means. |
…r#191420) flutter/packages@fdd7d39...1785501 2026-08-20 [email protected] [material_ui] Cleans up shader files and exposes ink_splash shader (flutter/packages#12421) 2026-08-19 [email protected] [material_ui] Fixes typo in code and tests (flutter/packages#12503) 2026-08-19 [email protected] [pigeon] Fixes lint error from unused codec (flutter/packages#12512) 2026-08-19 [email protected] [camera_android_camerax] Add explicit concurrent-futures dependency (flutter/packages#12373) 2026-08-19 [email protected] [go_router] migrates to material_ui and cupertino_ui (flutter/packages#12504) 2026-08-19 [email protected] [animations] Migrate to material_ui (flutter/packages#12467) 2026-08-19 [email protected] [material_ui] Add Material tokens (version 38.2.50) (flutter/packages#12471) 2026-08-19 [email protected] Add `triage-design` label (flutter/packages#12488) 2026-08-19 [email protected] [google_maps_flutter_platform_interface] Fix PinConfig code sample (flutter/packages#12259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Migrates the animations package to the material_ui package.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2