Repository navigation
[pigeon] Fixes lint error from unused codec - #12512
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Pigeon to version 27.3.2, modifying the Dart generator to avoid generating an unused codec variable when a proxy API only contains static host methods. It also adds a test case to verify this behavior. The review feedback points out a syntax error in the test where an enum is referenced with a leading dot shorthand instead of its full name, and a typo in the changelog entry.
| name: 'method', | ||
| returnType: const TypeDeclaration.voidDeclaration(), | ||
| parameters: <Parameter>[], | ||
| location: .host, |
Contributor
There was a problem hiding this comment.
In Dart, enum values cannot be referenced with a leading dot shorthand like .host. It should be ApiLocation.host.
Suggested change
| location: .host, | |
| location: ApiLocation.host, |
| @@ -1,3 +1,7 @@ | |||
| ## 27.3.2 | |||
|
|
|||
| * [dart] Fixes lint warning from unused codec variable in Dart proxy classesg. | |||
Contributor
There was a problem hiding this comment.
There is a typo at the end of the line: classesg. should be classes..
Suggested change
| * [dart] Fixes lint warning from unused codec variable in Dart proxy classesg. | |
| * [dart] Fixes lint warning from unused codec variable in Dart proxy classes. |
tarrinneal
approved these changes
Aug 19, 2026
bparrishMines
added
the
autosubmit
pull Bot
pushed a commit
to Superoldman96/flutter
that referenced
this pull request
Aug 20, 2026
…r#191420) flutter/packages@fdd7d39...1785501 2026-08-20 [email protected] [material_ui] Cleans up shader files and exposes ink_splash shader (flutter/packages#12421) 2026-08-19 [email protected] [material_ui] Fixes typo in code and tests (flutter/packages#12503) 2026-08-19 [email protected] [pigeon] Fixes lint error from unused codec (flutter/packages#12512) 2026-08-19 [email protected] [camera_android_camerax] Add explicit concurrent-futures dependency (flutter/packages#12373) 2026-08-19 [email protected] [go_router] migrates to material_ui and cupertino_ui (flutter/packages#12504) 2026-08-19 [email protected] [animations] Migrate to material_ui (flutter/packages#12467) 2026-08-19 [email protected] [material_ui] Add Material tokens (version 38.2.50) (flutter/packages#12471) 2026-08-19 [email protected] Add `triage-design` label (flutter/packages#12488) 2026-08-19 [email protected] [google_maps_flutter_platform_interface] Fix PinConfig code sample (flutter/packages#12259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing flutter/flutter#183945.
Regenerating pigeon files will fix issue.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2