[go_router] migrates to material_ui and cupertino_ui by chunhtai · Pull Request #12504 · flutter/packages

chunhtai · 2026-08-18T23:16:27Z

fixes flutter/flutter#191133
fixes flutter/flutter#191132

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request updates the minimum supported SDK version to Flutter 3.44/Dart 3.12, simplifies several constructor initializations using initializing formals, and replaces imports of the official Flutter SDK Material library with a third-party material_ui package across the codebase, examples, and tests. Feedback indicates that migrating to the third-party material_ui package is incorrect for a core Flutter package and its examples, and these changes should be reverted to use the official Material library.

gemini-code-assist · 2026-08-18T23:17:38Z

  logging: ^1.0.0
+  material_ui: ^1.0.0
  meta: ^1.7.0


Adding material_ui as a dependency is incorrect. go_router is a core Flutter package and must rely on the official Material library (package:flutter/material.dart) provided by the Flutter SDK rather than an external third-party package.

logging: ^1.0.0\n meta: ^1.7.0

gemini-code-assist · 2026-08-18T23:17:38Z

 // ignore_for_file: diagnostic_describe_all_properties

-import 'package:flutter/material.dart';
+import 'package:material_ui/material_ui.dart';


Replacing package:flutter/material.dart with package:material_ui/material_ui.dart is incorrect. Please revert this import to use the official Flutter SDK Material library.

Suggested change

import 'package:material_ui/material_ui.dart';

import 'package:flutter/material.dart';

lol. Get with the times. :)

gemini-code-assist · 2026-08-18T23:17:39Z

  logging: ^1.0.0
+  material_ui: ^1.0.0
  shared_preferences: ^2.0.11


Adding material_ui as a dependency in the example is incorrect. The example should use the official Flutter SDK Material library.

logging: ^1.0.0\n shared_preferences: ^2.0.11

chunhtai · 2026-08-18T23:18:37Z

 - [State restoration](https://pub.dev/documentation/go_router/latest/topics/State%20restoration-topic.html)

 ## Migration Guides
+- [Migrating to 18.0.0](https://flutter.dev/go/go-router-v18-breaking-changes).


flutter/website#13747

jonmountjoy · 2026-08-19T12:19:01Z

@@ -4,8 +4,8 @@

 import 'package:collection/collection.dart';
 import 'package:flutter/cupertino.dart';


This PR doesn't complete the job. There are two parts to the split - one is material_ui, and the other is cupertino_ui, and these need to be migrated as well.

jonmountjoy · 2026-08-19T12:21:23Z

@chunhtai unfortunately I suspect that this migration (great start) is incomplete. It misses completely all the cupertino => cupertino_ui (mirroring the Material), which will play a role in things like the following working correctly:

packages/packages/go_router/lib/src/pages/cupertino.dart

Line 11 in a3e763e

bool isCupertinoApp(BuildContext context) =>

Piinks · 2026-08-19T15:21:52Z

Yes, this should adopt cupertino_ui as well.

chunhtai · 2026-08-19T15:51:30Z

oh i totally missed that. thanks for reminding

chunhtai · 2026-08-19T17:01:22Z

ready for another look

jonmountjoy · 2026-08-19T17:13:22Z

-  sdk: ^3.10.0
-  flutter: ">=3.38.0"
+  sdk: ^3.12.0
+  flutter: ">=3.44.0"


I wonder about this, @chunhtai . Should it be 3.44.0?
I mean the material_ui/cupertino_ui split only came in 3.47.0

Maybe it's backward compatible? I have no idea.

I see the cupertino_ui says it's compatible from 3.44.0 - so perhaps this is good to go...
https://github.com/flutter/packages/blob/main/packages/cupertino_ui/pubspec.yaml

I was following this comment in this pr #12467 (comment)

oh this is to match the lower bound for material_ui

packages/packages/material_ui/pubspec.yaml

Line 9 in 1489576

flutter: ">=3.44.0"

Piinks

LGTM

justinmc · 2026-08-19T20:24:43Z

@chunhtai did you run the dart fix to do this? Did it work?

chunhtai · 2026-08-20T14:34:41Z

@chunhtai did you run the dart fix to do this? Did it work?

ah I forgot we can do that, I manually fix it with help of gemini

…r#191420) flutter/packages@fdd7d39...1785501 2026-08-20 [email protected] [material_ui] Cleans up shader files and exposes ink_splash shader (flutter/packages#12421) 2026-08-19 [email protected] [material_ui] Fixes typo in code and tests (flutter/packages#12503) 2026-08-19 [email protected] [pigeon] Fixes lint error from unused codec (flutter/packages#12512) 2026-08-19 [email protected] [camera_android_camerax] Add explicit concurrent-futures dependency (flutter/packages#12373) 2026-08-19 [email protected] [go_router] migrates to material_ui and cupertino_ui (flutter/packages#12504) 2026-08-19 [email protected] [animations] Migrate to material_ui (flutter/packages#12467) 2026-08-19 [email protected] [material_ui] Add Material tokens (version 38.2.50) (flutter/packages#12471) 2026-08-19 [email protected] Add `triage-design` label (flutter/packages#12488) 2026-08-19 [email protected] [google_maps_flutter_platform_interface] Fix PinConfig code sample (flutter/packages#12259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

justinmc · 2026-08-20T21:53:36Z

No worries, I'm we have multiple migration paths that seem to work!

[go_router] migrates to material_ui

6487e8a

flutter-dashboard Bot added the CICD Run CI/CD label Aug 18, 2026

chunhtai requested review from Piinks and stuartmorgan-g August 18, 2026 23:16

gemini-code-assist Bot reviewed Aug 18, 2026

View reviewed changes

chunhtai commented Aug 18, 2026

View reviewed changes

github-actions Bot added p: go_router triage-framework Should be looked at in framework triage labels Aug 18, 2026

jonmountjoy reviewed Aug 19, 2026

View reviewed changes

add cupertino

7e2b64e

chunhtai changed the title ~~[go_router] migrates to material_ui~~ [go_router] migrates to material_ui and cupertino_ui Aug 19, 2026

chunhtai and others added 2 commits August 19, 2026 09:47

Merge branch 'main' into issues/191133

f41601e

update

d359a46

chunhtai requested a review from jonmountjoy August 19, 2026 17:01

jonmountjoy reviewed Aug 19, 2026

View reviewed changes

chunhtai mentioned this pull request Aug 19, 2026

[go_router] material_ui MaterialApp routes lose platform transitions flutter/flutter#191132

Closed

Piinks approved these changes Aug 19, 2026

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2026

auto-submit Bot merged commit ed5bd29 into flutter:main Aug 19, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Aug 20, 2026

Roll Packages from fdd7d390e2a7 to 1785501174f3 (9 revisions) flutter/flutter#191420

Merged

luanbatistadenga mentioned this pull request Sep 14, 2026

[go_router] 18.0.0 drops platform transitions for apps using the SDK MaterialApp (inverse of #191132) flutter/flutter#192761

Open

	import 'package:material_ui/material_ui.dart';
	import 'package:flutter/material.dart';

		@@ -4,8 +4,8 @@

		import 'package:collection/collection.dart';
		import 'package:flutter/cupertino.dart';

Conversation

chunhtai commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Piinks Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

jonmountjoy Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jonmountjoy commented Aug 19, 2026

Uh oh!

Piinks commented Aug 19, 2026

Uh oh!

chunhtai commented Aug 19, 2026

Uh oh!

chunhtai commented Aug 19, 2026

Uh oh!

jonmountjoy Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

jonmountjoy Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc commented Aug 19, 2026

Uh oh!

chunhtai commented Aug 20, 2026

Uh oh!

justinmc commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chunhtai commented Aug 18, 2026 •

edited

Loading