Repository navigation
[SYCL][DOC] Added group sorting algorithms - #3514
Merged
Merged
Conversation
bader
added
the
spec extension
Contributor
Author
|
|
Contributor
Author
|
I think the PR is ready for merging. |
gmlueck
reviewed
Apr 21, 2021
Contributor
Author
|
By the way, key-value interface (keys are compared, but keys and values both are moved) can be expressed using auto first_zip = oneapi::dpl::make_zip_iterator( keys_first, values_first );
joint_sort( g, first_zip, first_zip + n, [ ]( auto x, auto y ){ return std::get<0>(x) < std::get<0>(y); } ); |
Contributor
Author
|
Does anyone have any more comments or questions? |
bader
reviewed
Apr 26, 2021
bader
left a comment
bader
left a comment
Contributor
There was a problem hiding this comment.
Does anyone have any more comments or questions?
Please, resolve merge conflicts in sycl/doc/extensions/README.md.
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Contributor
Author
Done |
bader
approved these changes
Apr 26, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 28, 2021
* upstream/sycl: [SYCL][Doc] Add group sorting algorithms extension specification (intel#3514) [Buildbot] Update Windows GPU driver to 27.20.100.9466 (intel#3594) [SYCL][NFC] Update tests for FPGA attributes (intel#3632) [CODEOWNERS] Add @kbobrovs back to few projects (intel#3638) [NFC] Update codeowners (intel#3619) [SYCL] Support 3-, 16-elements vectors in SG load/store (intel#3617) [SYCL-PTX] Fix libclc dependencies (intel#3624) [SYCL] Add sycl::span for SYCL2020 support (intel#3569) [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620) [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468) [SYCL][PI][L0] Submit open command batch on event status query (intel#3612) [NFC] Fix the comment (intel#3613) Rename misleading attribute flag (intel#3610) [SYCL] Generate an opt report of kernel arguments. (intel#3492) [SYCL] Support extra environment variables in LIT (intel#3598) [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
bader
pushed a commit
that referenced
this pull request
Aug 27, 2021
…d memory (#3989) Previously it was found that we need an additional local memory for more performant implementation. The proposal fixes it. Previous version of proposal was discussed here: #3514 Design review: #3754 Signed-off-by: Fedorov, Andrey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extension add the following:
joint_sort,sort_over_groupalgorithmssorterthat is a special type that let SYCL backends choose a method for sorting (e. g. radix sort, ...).default_sorter,radix_sorterFor future:
Signed-off-by: Fedorov, Andrey [email protected]