Repository navigation
[SYCL] Support extra environment variables in LIT - #3598
Merged
Merged
Conversation
Add ability to set extra environment variables in CMake (LIT_EXTRA_ENVIRONMENT) or LIT (extra_environment) parameters. The value should contain comma separated VARIABLE=VALUE pairs.
smaslov-intel
suggested changes
Apr 22, 2021
smaslov-intel
left a comment
smaslov-intel
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just let's document this somewhere how to use it.
Contributor
Author
The LIT infra for sycl/test is not documented. Will do that in separate PR. |
Contributor
OK |
smaslov-intel
approved these changes
Apr 23, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 27, 2021
* upstream/sycl: [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620) [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468) [SYCL][PI][L0] Submit open command batch on event status query (intel#3612) [NFC] Fix the comment (intel#3613) Rename misleading attribute flag (intel#3610) [SYCL] Generate an opt report of kernel arguments. (intel#3492) [SYCL] Support extra environment variables in LIT (intel#3598) [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 28, 2021
* upstream/sycl: [SYCL][Doc] Add group sorting algorithms extension specification (intel#3514) [Buildbot] Update Windows GPU driver to 27.20.100.9466 (intel#3594) [SYCL][NFC] Update tests for FPGA attributes (intel#3632) [CODEOWNERS] Add @kbobrovs back to few projects (intel#3638) [NFC] Update codeowners (intel#3619) [SYCL] Support 3-, 16-elements vectors in SG load/store (intel#3617) [SYCL-PTX] Fix libclc dependencies (intel#3624) [SYCL] Add sycl::span for SYCL2020 support (intel#3569) [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620) [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468) [SYCL][PI][L0] Submit open command batch on event status query (intel#3612) [NFC] Fix the comment (intel#3613) Rename misleading attribute flag (intel#3610) [SYCL] Generate an opt report of kernel arguments. (intel#3492) [SYCL] Support extra environment variables in LIT (intel#3598) [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
jsji
pushed a commit
that referenced
this pull request
Mar 19, 2026
This makes LLVM detection deterministic and ensures we use LLVM’s supported CMake integration (`LLVMConfig.cmake`) rather than potentially picking up an environment-provided `FindLLVM.cmake` module. * Out-of-tree builds require `LLVMConfig.cmake` to be discoverable (set `LLVM_DIR` / `CMAKE_PREFIX_PATH` if needed). * In-tree builds are unaffected (the external `find_package(LLVM ...)` path isn’t used there). Original commit: KhronosGroup/SPIRV-LLVM-Translator@ee801714f0d5f85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to set extra environment variables in CMake (LIT_EXTRA_ENVIRONMENT)
or LIT (extra_environment) parameters. The value should contain comma separated
VARIABLE=VALUE pairs.