Repository navigation
[NFC][SYCL] Avoid -Wreorder warning about order of initialization - #3620
Conversation
|
I hadn't noticed that warning. How did you get it? |
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
I'd rather keep the unique_ptr declarations together and change the order of the ctor initializers, but that's purely an aesthetic choice to keep like-types grouped together. WDYT?
I am okay with that too. This just was easier. :-) |
Just a ninja build using the process here: https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#build-dpc-toolchain |
I'm a bit surprised that CI didn't pick up the additional warning before we committed it. Do we not do |
MSVC didn't warn. |
Signed-off-by: Premanand M Rao <[email protected]>
722e469 to
2075462
Compare
* upstream/sycl: [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620) [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468) [SYCL][PI][L0] Submit open command batch on event status query (intel#3612) [NFC] Fix the comment (intel#3613) Rename misleading attribute flag (intel#3610) [SYCL] Generate an opt report of kernel arguments. (intel#3492) [SYCL] Support extra environment variables in LIT (intel#3598) [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
* upstream/sycl: [SYCL][Doc] Add group sorting algorithms extension specification (intel#3514) [Buildbot] Update Windows GPU driver to 27.20.100.9466 (intel#3594) [SYCL][NFC] Update tests for FPGA attributes (intel#3632) [CODEOWNERS] Add @kbobrovs back to few projects (intel#3638) [NFC] Update codeowners (intel#3619) [SYCL] Support 3-, 16-elements vectors in SG load/store (intel#3617) [SYCL-PTX] Fix libclc dependencies (intel#3624) [SYCL] Add sycl::span for SYCL2020 support (intel#3569) [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620) [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468) [SYCL][PI][L0] Submit open command batch on event status query (intel#3612) [NFC] Fix the comment (intel#3613) Rename misleading attribute flag (intel#3610) [SYCL] Generate an opt report of kernel arguments. (intel#3492) [SYCL] Support extra environment variables in LIT (intel#3598) [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
The `llvm-X-tools` apt package previously shipped `lit` as a Python script at `build/utils/lit/lit.py`. This path was removed in the Debian/Ubuntu packaging of LLVM 23: ["Install a lit binary"](https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/bedcb23bc00c9fe407725803d73e50ec6c8ecaf9) The packaging now installs a compiled `lit` binary at `bin/lit` instead, with a `/usr/bin/lit-X` symlink. Updated LLVM_EXTERNAL_LIT` to match the new location. Original commit: KhronosGroup/SPIRV-LLVM-Translator@3c31709bed67c66
5 participants
In the OptRecordFileRAII constructor, Ctx is initialized before OldDiagnosticHandler.
Change the order of declaration of these data members to avoid a -Wreorder warning.
Signed-off-by: Premanand M Rao [email protected]