Skip to content

1_1_0 release - #6448

Merged
Sean McManus (sean-mcmanus) merged 55 commits into
releasefrom
seanmcm/1_1_0_release
Nov 5, 2020
Merged

Sean McManus (sean-mcmanus) merged 55 commits into
releasefrom
seanmcm/1_1_0_release

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

No description provided.

Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
Co-authored-by: vs-mobiletools-engineering-service2 <[email protected]>
Co-authored-by: vs-mobiletools-engineering-service2 <[email protected]>
* Update changelog.
* Fix 'Build and Debug Active File' race condition with EngineLogs

If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and `${fileBasenameNoExtension}` will resolve to something similar to `./extension-output-#5`.

This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario.
This PR uses the
DebugConfigurationProvider.resolveDebugConfigurationWithSubstitutedVariables
which allows the debug configuration to wait for the preLaunchTask to
complete before continuing on and resolving variables that may have been
set in the 'tasks.json'.

This also resolves the logging issue where the 'Build and Debug Active
File' preLaunchTask uses the current file but we switch to the output
window for logging.
* copy ClientCollection.ts

* copy extension.ts

* copy client.ts

* rename LS message

* create new file

* spath to path

* remove uri with logged telemtery

* fix linter errors

* fix linter errors 2

* fix linter error 3

* change warm start collection

* nit

* bring setDidOpenTime to the beginnign of didOpen

* reply to reviews
* Add intelliSenseUpdateDelay setting
* Typo: settings_spaceWithinSquareBracketse -> settings_spaceWithinSquareBrackets
* Fixes for Windows ARM64
* Update node types version.
Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
* [cppdbg] Support new sourceFileMap schema

For cppdbg, sourceFileMap can be used for binding breakpoints.
If keeping with the old format "<source-path>":"<target-path>", it will
always be used for breakpoints.

If you use the new:
"<compile-path>" : {
   "editorPath": "<target-path>",
   "useForBreakpoints": true
}

The sourceMap will only be used for frame enumeration.

* Fix linter issues

* Addressing PR comments
* dont overwrite options and args

* linter error

* update changelog
Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
Add resolveDebugConfigurationWithSubstitutedVariables for
configurationProviders.

Keeping resolveDebugConfiguration to return null if type is not provided
in order to prompt `provideDebugConfiguration`.
* fix tab issues on g++ on windows

* add ;

* windows+linux verified
* show details of the compiler path

* remove detail from launch.json

* rename noDetailConfig

* lint error

* add comments
Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
Co-authored-by: DevDiv Build Lab - Dev14 <[email protected]>
* insiders 4

* order

* order 2

* PR #
* shows details correctly

* change default name

* generating unique names

* lint errors

* lint errors

* modify resolvetask

* modify details
@sean-mcmanus
Sean McManus (sean-mcmanus) requested a review from a team November 5, 2020 23:27
@sean-mcmanus
Sean McManus (sean-mcmanus) merged commit 83df900 into release Nov 5, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 21, 2020
@bobbrow
Bob Brown (bobbrow) deleted the seanmcm/1_1_0_release branch January 5, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants