Skip to content

[material_ui] Remove no-shuffle from progress indicator test - #12505

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
ValentinVignal:material_ui/test/remove-no-shuffle-from-progress-indicator-test
Aug 27, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:mainfrom
ValentinVignal:material_ui/test/remove-no-shuffle-from-progress-indicator-test

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#85160

Port of flutter/flutter#186655

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 19, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'no-shuffle' tag and its associated explanatory comment from the progress_indicator_test.dart file, allowing the test suite to run with randomized ordering. There are no review comments, and I have no feedback to provide.

@dkwingsmt
dkwingsmt self-requested a review August 19, 2026 18:33

@justinmc justinmc left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . This doesn't need a pending changelog file since it only affects a test. There was a test failure but it was a timeout, I've rerun it.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@auto-submit

auto-submit Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12505, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026
@github-actions github-actions Bot added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 25, 2026
@auto-submit

auto-submit Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12505, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026
@dkwingsmt

Copy link
Copy Markdown
Contributor

These files are not formatted correctly (see diff below):
  packages/material_ui/tool/gen_defaults/analysis_options.yaml

To fix run the repository tooling `format` command: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
or copy-paste this command into your terminal:
patch -p1 <<DONE
diff --git a/packages/material_ui/tool/gen_defaults/analysis_options.yaml b/packages/material_ui/tool/gen_defaults/analysis_options.yaml
index 1fb98de01a..f2aa106eb6 100644
--- a/packages/material_ui/tool/gen_defaults/analysis_options.yaml
+++ b/packages/material_ui/tool/gen_defaults/analysis_options.yaml
@@ -2,3 +2,6 @@ include: ../../../../analysis_options.yaml
 
 formatter:
   page_width: 100
+analyzer:
+  exclude:
+    - build/**

@ValentinVignal

Copy link
Copy Markdown
Contributor Author

@dkwingsmt I'm very confused by this error haha, let me try to rebase the branch to see if the issue is fixed

@ValentinVignal
ValentinVignal force-pushed the material_ui/test/remove-no-shuffle-from-progress-indicator-test branch from db2873e to a3ef393 Compare August 26, 2026 08:18
@justinmc

Copy link
Copy Markdown
Contributor

I saw 3 timeouts and reran them.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit

auto-submit Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12505, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2026
@auto-submit

auto-submit Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12505, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2026
@auto-submit
auto-submit Bot merged commit 64bd660 into flutter:main Aug 27, 2026
13 checks passed
pull Bot pushed a commit to Mu-L/flutter that referenced this pull request Aug 28, 2026
…er#191965)

flutter/packages@bd3cbc1...cd4cdd0

2026-08-28 [email protected] [material_ui] Add
all M3 templates and generated code to `temporarily_excluded/` before
migration (flutter/packages#12661)
2026-08-28 [email protected] Roll Flutter from
15d8908 to e8dca90 (58 revisions) (flutter/packages#12660)
2026-08-28 [email protected] [various] Update pigeon dev_dependency to
^27.3.2 (flutter/packages#12615)
2026-08-27 [email protected]
[camera_android_camerax] Enforce CHANGELOG backticks and add eval commit
author check to pre-push-skill (flutter/packages#12624)
2026-08-27 [email protected] [material_ui] Prevent stale async
suggestions in SearchAnchor (flutter/packages#12478)
2026-08-27 [email protected] [go_router_builder] Support analyzer 14
(flutter/packages#12614)
2026-08-27 [email protected] [cupertino_ui] Use super parameters in
more places (flutter/packages#12459)
2026-08-27 [email protected]
[material_ui] Remove no-shuffle from progress indicator test
(flutter/packages#12505)
2026-08-27 [email protected]
[two_dimensional_scrollables] Activate leak testing and fix memory leaks
(flutter/packages#11653)
2026-08-27 [email protected] [material_ui] Add
helper methods in gen_defaults template (flutter/packages#12637)
2026-08-27 [email protected] [cupertino_ui] fix CupertinoIcons
font not being included in examples and fix TextEditingController leaks
(flutter/packages#12228)
2026-08-27 [email protected]
[camera_android_camerax] Check Git hooks configuration in
check-readiness skill (flutter/packages#12628)
2026-08-27 [email protected] [ci] sync back pr
for branch release only run when release succeeds
(flutter/packages#12581)
2026-08-27 [email protected] [google_maps_flutter] Convert overlay
controllers to Swift (flutter/packages#12638)
2026-08-27 [email protected]
[go_router_builder] Fixes text golden test to ignore platform specific
newline (flutter/packages#12652)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…#12505)

Part of flutter/flutter#85160

Port of flutter/flutter#186655

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…#12505)

Part of flutter/flutter#85160

Port of flutter/flutter#186655

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants