[material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration by elliette · Pull Request #12661 · flutter/packages

elliette · 2026-08-27T20:06:20Z

Work towards flutter/flutter#191088

Ports over #12206 which landed on the m3e_migration feature branch.

Original PR description

Moves all M3 templates and their generated code to gen_defaults/temporarily_excluded before we begin migrating.

This way when we migrate each component, we can first move the template and its respective generated code into the new directories, edit the template, and re-generate the code. This will make it easier to review changes to the templates and validate the generated output.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…_excluded/` before migration (flutter#12206)

gemini-code-assist

Code Review

This pull request introduces a large set of generated Material 3 defaults and corresponding templates under a temporarily excluded directory, along with an exclusion rule in analysis_options.yaml. The feedback highlights several runtime safety issues where token values are cast directly to double. Since these values can be parsed as int from JSON, the reviewer recommends casting them to num first in motion_template.dart, typography_template.dart, and input_decorator_template.dart to prevent potential TypeError exceptions.

gemini-code-assist · 2026-08-27T20:42:50Z

+          (MapEntry<String, dynamic> a, MapEntry<String, dynamic> b) =>
+              (a.value as double).compareTo(b.value as double),


Casting a.value directly to double will throw a TypeError at runtime if the value is parsed as an int (which is common for whole numbers in JSON). Casting to num instead is safer and supports both int and double values.

Suggested change

(MapEntry<String, dynamic> a, MapEntry<String, dynamic> b) =>

(a.value as double).compareTo(b.value as double),

(MapEntry<String, dynamic> a, MapEntry<String, dynamic> b) =>

(a.value as num).compareTo(b.value as num),

gemini-code-assist · 2026-08-27T20:42:50Z

+  String durationTokenString(String token, dynamic tokenValue) {
+    tokensLogger.log(token);
+    final String tokenName = token.split('.').last.replaceAll('-', '').replaceFirst('Ms', '');
+    final int milliseconds = (tokenValue as double).toInt();


Casting tokenValue directly to double will throw a TypeError at runtime if the value is parsed as an int. Casting to num before calling toInt() is safer and supports both int and double values.

Suggested change

final int milliseconds = (tokenValue as double).toInt();

final int milliseconds = (tokenValue as num).toInt();

gemini-code-assist · 2026-08-27T20:42:51Z

+    final size = getToken('$textStyleTokenName.size') as double;
+    final lineHeight = getToken('$textStyleTokenName.line-height') as double;


Casting the token values directly to double will throw a TypeError at runtime if they are parsed as int (e.g., whole numbers like 12 or 16). Casting to num and calling toDouble() is safer and supports both int and double values.

Suggested change

final size = getToken('$textStyleTokenName.size') as double;

final lineHeight = getToken('$textStyleTokenName.line-height') as double;

final double size = (getToken('$textStyleTokenName.size') as num).toDouble();

final double lineHeight = (getToken('$textStyleTokenName.line-height') as num).toDouble();

gemini-code-assist · 2026-08-27T20:42:51Z

+    final width =
+        (getToken('$componentToken1.width', optional: true) ??
+                getToken('$componentToken1.height', optional: true) ??
+                getToken('$componentToken2.width', optional: true) ??
+                getToken('$componentToken2.height', optional: true) ??
+                1.0)
+            as double;


Casting the width/height token value directly to double will throw a TypeError at runtime if the value is parsed as an int. Casting to num and calling toDouble() is safer and supports both int and double values.

Suggested change

final width =

(getToken('$componentToken1.width', optional: true) ??

getToken('$componentToken1.height', optional: true) ??

getToken('$componentToken2.width', optional: true) ??

getToken('$componentToken2.height', optional: true) ??

1.0)

as double;

final double width =

((getToken('$componentToken1.width', optional: true) ??

getToken('$componentToken1.height', optional: true) ??

getToken('$componentToken2.width', optional: true) ??

getToken('$componentToken2.height', optional: true) ??

1.0) as num).toDouble();

QuncCccccc

LGTM! Thanks for porting it over!

Just to double check, we don't need CHANGELOG entries for any gen_defaults changes right?

elliette · 2026-08-27T21:09:42Z

Just to double check, we don't need CHANGELOG entries for any gen_defaults changes right?

Nope, as long as all the changes are in gen_defaults we don't need a CHANGELOG since gen_defaults is not published.

…er#191965) flutter/packages@bd3cbc1...cd4cdd0 2026-08-28 [email protected] [material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration (flutter/packages#12661) 2026-08-28 [email protected] Roll Flutter from 15d8908 to e8dca90 (58 revisions) (flutter/packages#12660) 2026-08-28 [email protected] [various] Update pigeon dev_dependency to ^27.3.2 (flutter/packages#12615) 2026-08-27 [email protected] [camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill (flutter/packages#12624) 2026-08-27 [email protected] [material_ui] Prevent stale async suggestions in SearchAnchor (flutter/packages#12478) 2026-08-27 [email protected] [go_router_builder] Support analyzer 14 (flutter/packages#12614) 2026-08-27 [email protected] [cupertino_ui] Use super parameters in more places (flutter/packages#12459) 2026-08-27 [email protected] [material_ui] Remove no-shuffle from progress indicator test (flutter/packages#12505) 2026-08-27 [email protected] [two_dimensional_scrollables] Activate leak testing and fix memory leaks (flutter/packages#11653) 2026-08-27 [email protected] [material_ui] Add helper methods in gen_defaults template (flutter/packages#12637) 2026-08-27 [email protected] [cupertino_ui] fix CupertinoIcons font not being included in examples and fix TextEditingController leaks (flutter/packages#12228) 2026-08-27 [email protected] [camera_android_camerax] Check Git hooks configuration in check-readiness skill (flutter/packages#12628) 2026-08-27 [email protected] [ci] sync back pr for branch release only run when release succeeds (flutter/packages#12581) 2026-08-27 [email protected] [google_maps_flutter] Convert overlay controllers to Swift (flutter/packages#12638) 2026-08-27 [email protected] [go_router_builder] Fixes text golden test to ignore platform specific newline (flutter/packages#12652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…_excluded/` before migration (flutter#12661) Work towards flutter/flutter#191088 **Ports over flutter#12206 which landed on the `m3e_migration` feature branch.** ### Original PR description Work towards flutter/flutter#187899 Moves all M3 templates and their generated code to gen_defaults/temporarily_excluded before we begin migrating. This way when we migrate each component, we can first move the template and its respective generated code into the new directories, edit the template, and re-generate the code. This will make it easier to review changes to the templates and validate the generated output. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

[material_ui] Add all M3 templates and generated code to `temporarily…

7befafe

…_excluded/` before migration (flutter#12206)

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 27, 2026

Move analysis exclusion to gen_defaults subdirectory

d8e4ad5

elliette added the CICD Run CI/CD label Aug 27, 2026

Committed in wrong directory

1be791e

elliette marked this pull request as ready for review August 27, 2026 20:40

elliette requested a review from QuncCccccc August 27, 2026 20:41

gemini-code-assist Bot reviewed Aug 27, 2026

View reviewed changes

elliette mentioned this pull request Aug 27, 2026

[material_ui] Port PRs from m3e_migration feature branch to main branch flutter/flutter#191088

Closed

QuncCccccc approved these changes Aug 27, 2026

View reviewed changes

Run format

3f88fe6

elliette added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2026

auto-submit Bot merged commit cd4cdd0 into flutter:main Aug 28, 2026
13 checks passed

engine-flutter-autoroll mentioned this pull request Aug 28, 2026

Roll Packages from bd3cbc1b8c3f to cd4cdd0a044b (15 revisions) flutter/flutter#191965

Merged

Navigation Menu

Repository navigation

[material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration - #12661

[material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration#12661
auto-submit[bot] merged 4 commits into
flutter:mainfrom
elliette:port-pr-12206

elliette commented Aug 27, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Uh oh!

QuncCccccc left a comment

Uh oh!

elliette commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		(MapEntry<String, dynamic> a, MapEntry<String, dynamic> b) =>
		(a.value as double).compareTo(b.value as double),

	final int milliseconds = (tokenValue as double).toInt();
	final int milliseconds = (tokenValue as num).toInt();

		final size = getToken('$textStyleTokenName.size') as double;
		final lineHeight = getToken('$textStyleTokenName.line-height') as double;

Conversation

elliette commented Aug 27, 2026

Original PR description

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

elliette commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants