Repository navigation
[ci] sync back pr for branch release only run when release succeeds - #12581
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the validation of the sync_release_pr.yml global workflow trigger from RepoInfoValidator and deletes all associated test cases, helpers, and assertions in validate_command_repo_info_test.dart. There are no review comments, and there is no feedback to provide.
justinmc
approved these changes
Aug 24, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
Conceptually LGTM though I'm less familiar with the validate_command_repo_info_test.dart code here.
Contributor
Author
script/tool/lib/src/validators/repo_info_validator.dart and its test is for ci to validate batch release package has also edited the batch release workflow to include that package. This is to prevent people from opt in package without update all the necessary file The reason it needs to be modify is that sync_to_main.yml is removed to be merge with release_from_branch.yml, so that it is one less place for repo_info_validator to verify whether the correct file is modified |
Contributor
|
Thank you for the explanation, sounds good! |
stuartmorgan-g
approved these changes
Aug 25, 2026
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once comments are added
| jobs: | ||
| release: | ||
| permissions: | ||
| contents: write |
Collaborator
There was a problem hiding this comment.
Here and below, permission grants should have comments explaining why, as the removed code did.
chunhtai
added
the
autosubmit
chunhtai
changed the title
Contributor
|
autosubmit label was removed for flutter/packages/12581, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
chunhtai
added
the
autosubmit
This was referenced Aug 28, 2026
pull Bot
pushed a commit
to Mu-L/flutter
that referenced
this pull request
Aug 28, 2026
…er#191965) flutter/packages@bd3cbc1...cd4cdd0 2026-08-28 [email protected] [material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration (flutter/packages#12661) 2026-08-28 [email protected] Roll Flutter from 15d8908 to e8dca90 (58 revisions) (flutter/packages#12660) 2026-08-28 [email protected] [various] Update pigeon dev_dependency to ^27.3.2 (flutter/packages#12615) 2026-08-27 [email protected] [camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill (flutter/packages#12624) 2026-08-27 [email protected] [material_ui] Prevent stale async suggestions in SearchAnchor (flutter/packages#12478) 2026-08-27 [email protected] [go_router_builder] Support analyzer 14 (flutter/packages#12614) 2026-08-27 [email protected] [cupertino_ui] Use super parameters in more places (flutter/packages#12459) 2026-08-27 [email protected] [material_ui] Remove no-shuffle from progress indicator test (flutter/packages#12505) 2026-08-27 [email protected] [two_dimensional_scrollables] Activate leak testing and fix memory leaks (flutter/packages#11653) 2026-08-27 [email protected] [material_ui] Add helper methods in gen_defaults template (flutter/packages#12637) 2026-08-27 [email protected] [cupertino_ui] fix CupertinoIcons font not being included in examples and fix TextEditingController leaks (flutter/packages#12228) 2026-08-27 [email protected] [camera_android_camerax] Check Git hooks configuration in check-readiness skill (flutter/packages#12628) 2026-08-27 [email protected] [ci] sync back pr for branch release only run when release succeeds (flutter/packages#12581) 2026-08-27 [email protected] [google_maps_flutter] Convert overlay controllers to Swift (flutter/packages#12638) 2026-08-27 [email protected] [go_router_builder] Fixes text golden test to ignore platform specific newline (flutter/packages#12652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…lutter#12581) Currently sync back pr for batch release is created as soon as the batch release PR merges. This can be a problem if the release workflow runs on the release branch fails and someone accidentally merge the sync back pr without knowing. It will be extremely hard to clean up in this case. The PR changes it that the sync back pr is only created when release finishes successfully. After this change, if release fails, we can simply delete the release branch and re trigger the batch release workflow to try again. Merging this PR carry a risk if there is bug in the new code in release_from_branch workflow. If you don't see a sync back pr the next time batch release, let me know and i can help clean up and fix. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…lutter#12581) Currently sync back pr for batch release is created as soon as the batch release PR merges. This can be a problem if the release workflow runs on the release branch fails and someone accidentally merge the sync back pr without knowing. It will be extremely hard to clean up in this case. The PR changes it that the sync back pr is only created when release finishes successfully. After this change, if release fails, we can simply delete the release branch and re trigger the batch release workflow to try again. Merging this PR carry a risk if there is bug in the new code in release_from_branch workflow. If you don't see a sync back pr the next time batch release, let me know and i can help clean up and fix. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sync back pr for batch release is created as soon as the batch release PR merges.
This can be a problem if the release workflow runs on the release branch fails and someone accidentally merge the sync back pr without knowing. It will be extremely hard to clean up in this case.
The PR changes it that the sync back pr is only created when release finishes successfully.
After this change, if release fails, we can simply delete the release branch and re trigger the batch release workflow to try again.
Merging this PR carry a risk if there is bug in the new code in release_from_branch workflow. If you don't see a sync back pr the next time batch release, let me know and i can help clean up and fix.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2