[camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill by reidbaker-agent · Pull Request #12624 · flutter/packages

reidbaker-agent · 2026-08-25T18:34:01Z

This work started by adding evals to make sure the changlog backticks work did not regress. Then I discovered that the agents.md file I updated didn't work if the camera_android_camerax folder was opened which was the documented project-oneshot plan.

When authoring those evals I ran into issues branching the workspace. google/skills_lint.dart#3 addresses updating the skill to work in more situations.

This pr also adds some shared utilities and a script to verify that eval commits are not pushed.

@reidbaker

Agent authored description.
Enforces the repository-wide requirement that code references in CHANGELOG.md must be enclosed in backticks, and adds verification tooling to prevent pushing evaluation test commits.

Changes

1. CHANGELOG Backtick Enforcement

Updated pre-push-skill/SKILL.md to verify CHANGELOG.md formatting following the ecosystem contributing guidelines.
Linked package AGENTS.md to repository root AGENTS.md.
Added Eval 5 (setup_user_facing_docs_change.dart) to evaluate and assert detection of unquoted code references in CHANGELOG.md.

2. Eval Commit Prevention & Tooling

Created evals/tool/check_eval_commits.dart CLI tool using package:args and idiomatic exit code handling to verify that outgoing branch commits contain no forbidden evaluation author credentials ([email protected]).
Added Step 3 ("Check for Evaluation Test Commits") to pre-push-skill/SKILL.md.
Extracted shared author credentials and commit helpers into evals/tool/test_utils.dart and migrated all eval setup scripts to use it.
Added Eval 6 (setup_eval_commit_failure.dart) to evaluate and assert rejection of evaluation test commits.

Verification

flutter test test/skills_evals_test.dart
flutter test test/validate_skills_test.dart
dart analyze .agents/skills/pre-push-skill/ evals/
dart run evals/tool/check_eval_commits.dart --remote=origin
Ran full evaluation suite (Evals 1–6) with subagents in isolated worktrees.

gemini-code-assist

Code Review

This pull request updates the pre-push skill documentation, evaluation tests, and setup scripts to verify CHANGELOG.md formatting and version bumps. It adds a new evaluation case for user-facing documentation changes, updates the success setup script to bump versions and update the changelog, and introduces a new setup script for user-facing documentation changes. Feedback suggests checking the exit codes of git add and git commit commands in both setup scripts to ensure they fail visibly upon failure.

…cripts

…l commits

…, and document parameters

…heck

reidbaker · 2026-08-25T20:53:22Z

-    stdout.writeln('Error: Cannot run setup scripts on main branch.');
-    exit(1);
-  }
+  ensureNotMainBranch();


This was pre existing code that I extracted.

… exit codes, and auto-detect upstream remote

…ils.dart

…nd isolate test author credentials

…asing in check_eval_commits.dart

…evals

reidbaker · 2026-08-25T22:38:16Z

Eval ID	Scenario	Expected Behavior	Result
1	Missing Native Test (setup_missing_native_test.dart)	Fails Step 9; states code is NOT ready to push	PASSED
2	Full Success Path (setup_success_native_test.dart)	Passes all checks; confirms version & backticks; states code IS ready to push	PASSED
3	Mixed Missing Native Test (setup_mixed_missing_native_test.dart)	Fails Step 9; identifies missing Java unit test	PASSED
4	Explicit User Bypass (setup_missing_native_test.dart + override)	Acknowledges explicit bypass; states code IS ready to push	PASSED
5	Missing Backticks in CHANGELOG (setup_user_facing_docs_change.dart)	Fails Step 6; reports unquoted takePicture in CHANGELOG.md	PASSED
6	Evaluation Test Commits Detected (setup_eval_commit_author_failure.dart)	Fails Step 3; reports commits authored by [email protected]	PASSED

gemini-code-assist

Code Review

This pull request introduces a pre-push validation check to detect and prevent commits authored or committed with evaluation test credentials. It adds a check_eval_commits.dart tool, helper utilities in test_utils.dart, and corresponding evaluation test scenarios, while updating the SKILL.md documentation and pubspec.yaml dependencies. Feedback on the changes suggests refining the git log format to avoid false positives from commit messages and making the remote URL regex more robust by handling optional trailing slashes.

…e> | %s' and support trailing slash in remote URL

camsim99 · 2026-08-26T20:37:09Z

-    '-m',
-    'Add DummyEvalFeature.java without tests',
-  ]);
+  commitFiles(<String>[javaFile.path], 'Add DummyEvalFeature.java without tests');


Mostly just thinking aloud here but wanted to confirm your thinking:

I'm conflicted because I would think that this one and setup_mixed_native_test.dart should have the override to ensure the code is ready to push even when the author is valid. However, the eval still technically checks that the test check would fail individually, it just doesn't isolate that as the reason for determining that the code is not ready to push. I could see overriding the author in these cases being a slippery slope for doing the same for similar evals we'll likely add in the future that also modify code, and I'm not sure that it's a major value loss to not isolate reasons for the check failing. Wdyt?

"even when the author is valid" Or did you mean even when the author is invalid?
What I am trying to protect here is eval code getting pushed. Skills that modify code are totally fine and they would use the local git config.

FWIW this was a not a theoretical issue. Jetski ide changed the rules around when it can branch into a subagent with isolated code and this pr committed eval code and pushed it. See https://github.com/flutter/packages/compare/c9ae62501ef56d4382ea2047b14a3c3926111c71..c95fae1cbc1b23b2c98335f59dfaafe37488ffa3

Ah ok yes. What I was describing is the case where a pre-push eval results in "not ready to push" but that is now because (1) the original subject matter that we are actually evaluating and (2) the subagent pushed code to test the original subject matter. So now the conclusion "The eval failed because the original subject matter" is not technically true anymore.

At the end of the day, we need to protect subagents from pushing though so SGTM!

We talked offline. The issue is that my check for invalid author in evals should not be part of this pr and should be part of a pre push git hook. Will remove that part of the pr and get rereview.

Removed the commit author check from pre-push-skill and all corresponding evals. All 5 remaining evals and repo presubmit checks pass.

@reidbaker

…ness skill (#12628) This came up as part of #12624 I noticed that the pre-push skill passed my code but linux analyze failed. It was because I didnt realize that this checkout (I have 2) didnt have git hooks installed. - @reidbaker --- Agent authored description Updates the `check-readiness` skill to verify that Git pre-commit hooks (`script/githooks`) are configured in the repository (`core.hooksPath`). If unconfigured or pointing to an unexpected path, it provides actionable instructions to run `script/githooks/bin/install_hooks.dart`. Includes unit test coverage in `check_test.dart`. Part of flutter/flutter#188870 ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests --------- Co-authored-by: Reid Baker <[email protected]>

camsim99

LGTM!

…er#191965) flutter/packages@bd3cbc1...cd4cdd0 2026-08-28 [email protected] [material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration (flutter/packages#12661) 2026-08-28 [email protected] Roll Flutter from 15d8908 to e8dca90 (58 revisions) (flutter/packages#12660) 2026-08-28 [email protected] [various] Update pigeon dev_dependency to ^27.3.2 (flutter/packages#12615) 2026-08-27 [email protected] [camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill (flutter/packages#12624) 2026-08-27 [email protected] [material_ui] Prevent stale async suggestions in SearchAnchor (flutter/packages#12478) 2026-08-27 [email protected] [go_router_builder] Support analyzer 14 (flutter/packages#12614) 2026-08-27 [email protected] [cupertino_ui] Use super parameters in more places (flutter/packages#12459) 2026-08-27 [email protected] [material_ui] Remove no-shuffle from progress indicator test (flutter/packages#12505) 2026-08-27 [email protected] [two_dimensional_scrollables] Activate leak testing and fix memory leaks (flutter/packages#11653) 2026-08-27 [email protected] [material_ui] Add helper methods in gen_defaults template (flutter/packages#12637) 2026-08-27 [email protected] [cupertino_ui] fix CupertinoIcons font not being included in examples and fix TextEditingController leaks (flutter/packages#12228) 2026-08-27 [email protected] [camera_android_camerax] Check Git hooks configuration in check-readiness skill (flutter/packages#12628) 2026-08-27 [email protected] [ci] sync back pr for branch release only run when release succeeds (flutter/packages#12581) 2026-08-27 [email protected] [google_maps_flutter] Convert overlay controllers to Swift (flutter/packages#12638) 2026-08-27 [email protected] [go_router_builder] Fixes text golden test to ignore platform specific newline (flutter/packages#12652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@reidbaker

…ness skill (flutter#12628) This came up as part of flutter#12624 I noticed that the pre-push skill passed my code but linux analyze failed. It was because I didnt realize that this checkout (I have 2) didnt have git hooks installed. - @reidbaker --- Agent authored description Updates the `check-readiness` skill to verify that Git pre-commit hooks (`script/githooks`) are configured in the repository (`core.hooksPath`). If unconfigured or pointing to an unexpected path, it provides actionable instructions to run `script/githooks/bin/install_hooks.dart`. Includes unit test coverage in `check_test.dart`. Part of flutter/flutter#188870 ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests --------- Co-authored-by: Reid Baker <[email protected]>

@reidbaker

…mit author check to pre-push-skill (flutter#12624) This work started by adding evals to make sure the changlog backticks work did not regress. Then I discovered that the agents.md file I updated didn't work if the camera_android_camerax folder was opened which was the documented project-oneshot plan. When authoring those evals I ran into issues branching the workspace. google/skills_lint.dart#3 addresses updating the skill to work in more situations. This pr also adds some shared utilities and a script to verify that eval commits are not pushed. - @reidbaker --- Agent authored description. Enforces the repository-wide requirement that code references in `CHANGELOG.md` must be enclosed in backticks, and adds verification tooling to prevent pushing evaluation test commits. ## Changes ### 1. CHANGELOG Backtick Enforcement - Updated `pre-push-skill/SKILL.md` to verify `CHANGELOG.md` formatting following the ecosystem contributing guidelines. - Linked package `AGENTS.md` to repository root `AGENTS.md`. - Added Eval 5 (`setup_user_facing_docs_change.dart`) to evaluate and assert detection of unquoted code references in `CHANGELOG.md`. ### 2. Eval Commit Prevention & Tooling - Created `evals/tool/check_eval_commits.dart` CLI tool using `package:args` and idiomatic exit code handling to verify that outgoing branch commits contain no forbidden evaluation author credentials (`[email protected]`). - Added Step 3 ("Check for Evaluation Test Commits") to `pre-push-skill/SKILL.md`. - Extracted shared author credentials and commit helpers into `evals/tool/test_utils.dart` and migrated all eval setup scripts to use it. - Added Eval 6 (`setup_eval_commit_failure.dart`) to evaluate and assert rejection of evaluation test commits. ## Verification - `flutter test test/skills_evals_test.dart` - `flutter test test/validate_skills_test.dart` - `dart analyze .agents/skills/pre-push-skill/ evals/` - `dart run evals/tool/check_eval_commits.dart --remote=origin` - Ran full evaluation suite (Evals 1–6) with subagents in isolated worktrees.

@reidbaker

…ness skill (flutter#12628) This came up as part of flutter#12624 I noticed that the pre-push skill passed my code but linux analyze failed. It was because I didnt realize that this checkout (I have 2) didnt have git hooks installed. - @reidbaker --- Agent authored description Updates the `check-readiness` skill to verify that Git pre-commit hooks (`script/githooks`) are configured in the repository (`core.hooksPath`). If unconfigured or pointing to an unexpected path, it provides actionable instructions to run `script/githooks/bin/install_hooks.dart`. Includes unit test coverage in `check_test.dart`. Part of flutter/flutter#188870 ## Pre-Review Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates [semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions [repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests --------- Co-authored-by: Reid Baker <[email protected]>

@reidbaker

…mit author check to pre-push-skill (flutter#12624) This work started by adding evals to make sure the changlog backticks work did not regress. Then I discovered that the agents.md file I updated didn't work if the camera_android_camerax folder was opened which was the documented project-oneshot plan. When authoring those evals I ran into issues branching the workspace. google/skills_lint.dart#3 addresses updating the skill to work in more situations. This pr also adds some shared utilities and a script to verify that eval commits are not pushed. - @reidbaker --- Agent authored description. Enforces the repository-wide requirement that code references in `CHANGELOG.md` must be enclosed in backticks, and adds verification tooling to prevent pushing evaluation test commits. ## Changes ### 1. CHANGELOG Backtick Enforcement - Updated `pre-push-skill/SKILL.md` to verify `CHANGELOG.md` formatting following the ecosystem contributing guidelines. - Linked package `AGENTS.md` to repository root `AGENTS.md`. - Added Eval 5 (`setup_user_facing_docs_change.dart`) to evaluate and assert detection of unquoted code references in `CHANGELOG.md`. ### 2. Eval Commit Prevention & Tooling - Created `evals/tool/check_eval_commits.dart` CLI tool using `package:args` and idiomatic exit code handling to verify that outgoing branch commits contain no forbidden evaluation author credentials (`[email protected]`). - Added Step 3 ("Check for Evaluation Test Commits") to `pre-push-skill/SKILL.md`. - Extracted shared author credentials and commit helpers into `evals/tool/test_utils.dart` and migrated all eval setup scripts to use it. - Added Eval 6 (`setup_eval_commit_failure.dart`) to evaluate and assert rejection of evaluation test commits. ## Verification - `flutter test test/skills_evals_test.dart` - `flutter test test/validate_skills_test.dart` - `dart analyze .agents/skills/pre-push-skill/ evals/` - `dart run evals/tool/check_eval_commits.dart --remote=origin` - Ran full evaluation suite (Evals 1–6) with subagents in isolated worktrees.

reidbaker added 2 commits August 25, 2026 14:25

Enforce CHANGELOG code item backticks in pre-push-skill and evals

a268ce1

Add fallback to setup scripts for worktree support

48c2685

github-actions Bot added the p: camera label Aug 25, 2026

gemini-code-assist Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread ...android_camerax/.agents/skills/pre-push-skill/evals/test_data/setup_success_native_test.dart Outdated

Comment thread ...oid_camerax/.agents/skills/pre-push-skill/evals/test_data/setup_user_facing_docs_change.dart Outdated

reidbaker added 2 commits August 25, 2026 14:50

Cleanly encapsulate version and changelog logic in helper method

d9d6306

Use flutter_plugin_tools update-release-info directly in eval setup s…

a488940

…cripts

reidbaker marked this pull request as draft August 25, 2026 19:00

reidbaker added 2 commits August 25, 2026 15:10

Extract branch protection and git commit helpers into test_utils.dart

a810673

Use updateReleaseInfo repository helper across eval setup scripts

c95fae1

github-actions Bot added the platform-android label Aug 25, 2026

reidbaker force-pushed the enforce-changelog-backticks branch from c9ae625 to c95fae1 Compare August 25, 2026 20:10

github-actions Bot removed the platform-android label Aug 25, 2026

reidbaker added 6 commits August 25, 2026 16:18

Add commit author check tool and pre-push step to prevent pushing eva…

851e89b

…l commits

Support CLI flags in check_eval_commits.dart, remove ternary fallback…

723afdb

…, and document parameters

Use exitCode and return instead of exit() in check_eval_commits.dart

a99f7e5

Use package:args in check_eval_commits.dart

49713c3

Move check_eval_commits.dart and test_utils.dart to evals/tool/

66760e9

Add Eval 6 and setup_eval_commit_failure.dart to test commit author c…

146fc40

…heck

reidbaker-agent changed the title ~~[camera_android_camerax] Enforce CHANGELOG code item backticks in pre-push-skill and evals~~ [camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill Aug 25, 2026

reidbaker requested changes Aug 25, 2026

View reviewed changes

reidbaker added 10 commits August 25, 2026 16:57

Address review comments: rename eval setup script, add dartdoc, check…

d773378

… exit codes, and auto-detect upstream remote

Extract detectDefaultRemote to shared test_utils.dart

cf5b233

Improve detectDefaultRemote doc comment and implementation in test_ut…

a91fd84

…ils.dart

Address review feedback: refine exit codes, inline CHANGELOG rules, a…

e6bd68f

…nd isolate test author credentials

Use SCRIPT_ERROR prefix on git log failures in check_eval_commits.dart

a785ffd

Use exact evalAuthorEmail and evalAuthorName constants without lowerc…

59e0f07

…asing in check_eval_commits.dart

Rename forbidden variable and fail fast on first detected eval identity

e5536db

Revert changes to AGENTS.md to keep PR focused on pre-push skill and …

d35f2ed

…evals

Restore intentional Repository Guidelines reference in AGENTS.md

1f95401

Link to CHANGELOG style guide in SKILL.md without duplicating rules

126da9d

Format Dart files with flutter_plugin_tools format

1422db1

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 25, 2026

reidbaker mentioned this pull request Aug 25, 2026

[camera_android_camerax] Check Git hooks configuration in check-readiness skill #12628

Merged

11 tasks done

reidbaker marked this pull request as ready for review August 25, 2026 23:03

gemini-code-assist Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread packages/camera/camera_android_camerax/evals/tool/check_eval_commits.dart

Comment thread packages/camera/camera_android_camerax/evals/tool/test_utils.dart Outdated

Update git log format to '%h | Author: %an <%ae> | Committer: %cn <%c…

add7aac

…e> | %s' and support trailing slash in remote URL

reidbaker added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Aug 25, 2026

camsim99 reviewed Aug 26, 2026

View reviewed changes

Remove evaluation test commit author check from pre-push skill

2100bc4

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 27, 2026

reidbaker added 2 commits August 27, 2026 16:43

Add --no-verify to eval test fixture commits in test_utils.dart

0727b1d

Include stdout in commit failure error in test_utils.dart

d5ece3f

reidbaker force-pushed the enforce-changelog-backticks branch from 86b1070 to d5ece3f Compare August 27, 2026 20:43

reidbaker approved these changes Aug 27, 2026

View reviewed changes

camsim99 approved these changes Aug 27, 2026

View reviewed changes

reidbaker added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Aug 27, 2026

reidbaker mentioned this pull request Aug 27, 2026

[githooks] Add pre-push hook to prevent pushing evaluation test commits #12663

Draft

6 tasks done

auto-submit Bot merged commit 6bf42a8 into flutter:main Aug 27, 2026
14 checks passed

This was referenced Aug 28, 2026

Roll Packages from bd3cbc1b8c3f to 0bab4169c5ba (14 revisions) flutter/flutter#191961

Closed

Roll Packages from bd3cbc1b8c3f to cd4cdd0a044b (15 revisions) flutter/flutter#191965

Merged

Conversation

reidbaker-agent commented Aug 25, 2026 • edited by reidbaker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

1. CHANGELOG Backtick Enforcement

2. Eval Commit Prevention & Tooling

Verification

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

reidbaker commented Aug 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

camsim99 Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

camsim99 Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker-agent Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker-agent commented Aug 25, 2026 •

edited by reidbaker

Loading