Repository navigation
[go_router_builder] Fixes text golden test to ignore platform specific newline - #12652
Merged
Merged
Conversation
github-actions
Bot
added
p: go_router_builder
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function expectWithNormalizedNewline in run_tests.dart to normalize CRLF line endings to LF during test assertions, and updates existing assertions to use it. The review feedback suggests making this helper function private since it is only used within the same file.
chunhtai
changed the title
chunhtai
added
override: no versioning needed
Contributor
Author
|
reason for override: ci only change that doesn't affect any of the code and documentation |
Contributor
Author
|
presubmit passes https://ci.chromium.org/ui/p/flutter/builders/try/Windows_x64%20custom_package_tests%20master%20-%20packages/22330/overview but not sure if this is a good indication that the postsubmit issue is resolved |
Contributor
|
The tests fail on presubmit now, so it should pass post submit if it does for presubmit. |
bparrishMines
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
This was referenced Aug 28, 2026
pull Bot
pushed a commit
to Mu-L/flutter
that referenced
this pull request
Aug 28, 2026
…er#191965) flutter/packages@bd3cbc1...cd4cdd0 2026-08-28 [email protected] [material_ui] Add all M3 templates and generated code to `temporarily_excluded/` before migration (flutter/packages#12661) 2026-08-28 [email protected] Roll Flutter from 15d8908 to e8dca90 (58 revisions) (flutter/packages#12660) 2026-08-28 [email protected] [various] Update pigeon dev_dependency to ^27.3.2 (flutter/packages#12615) 2026-08-27 [email protected] [camera_android_camerax] Enforce CHANGELOG backticks and add eval commit author check to pre-push-skill (flutter/packages#12624) 2026-08-27 [email protected] [material_ui] Prevent stale async suggestions in SearchAnchor (flutter/packages#12478) 2026-08-27 [email protected] [go_router_builder] Support analyzer 14 (flutter/packages#12614) 2026-08-27 [email protected] [cupertino_ui] Use super parameters in more places (flutter/packages#12459) 2026-08-27 [email protected] [material_ui] Remove no-shuffle from progress indicator test (flutter/packages#12505) 2026-08-27 [email protected] [two_dimensional_scrollables] Activate leak testing and fix memory leaks (flutter/packages#11653) 2026-08-27 [email protected] [material_ui] Add helper methods in gen_defaults template (flutter/packages#12637) 2026-08-27 [email protected] [cupertino_ui] fix CupertinoIcons font not being included in examples and fix TextEditingController leaks (flutter/packages#12228) 2026-08-27 [email protected] [camera_android_camerax] Check Git hooks configuration in check-readiness skill (flutter/packages#12628) 2026-08-27 [email protected] [ci] sync back pr for branch release only run when release succeeds (flutter/packages#12581) 2026-08-27 [email protected] [google_maps_flutter] Convert overlay controllers to Swift (flutter/packages#12638) 2026-08-27 [email protected] [go_router_builder] Fixes text golden test to ignore platform specific newline (flutter/packages#12652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…c newline (flutter#12652) fixes flutter/flutter#191892 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
…c newline (flutter#12652) fixes flutter/flutter#191892 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#191892
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2