Skip to content

Update README.md SUGGESTIONS - #47

Closed
jadsongmatos wants to merge 1 commit into
v8:masterfrom
jadsongmatos:master
Closed

jadsongmatos wants to merge 1 commit into
v8:masterfrom
jadsongmatos:master

Conversation

@jadsongmatos

Copy link
Copy Markdown

232 SUGGESTIONS
Critical: 2
Warning: 37
Info: 99

@google-cla

google-cla Bot commented Dec 8, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@surma

surma commented Dec 8, 2020

Copy link
Copy Markdown

hm no

@surma surma closed this Dec 8, 2020
@jadsongmatos

Copy link
Copy Markdown
Author

@googlebot I signed it!

@jadsongmatos

Copy link
Copy Markdown
Author

hm não
doesn't that suggestion make sense ?

tools/turbolizer/src/ source-resolver.ts
typeof [:32] is compared [:32] to undefined [:32] . This comparison is invalid, because typeof always returns strings.

Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
…lug.

Revision: d8e1f4d

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I5c67f6ac3983bae8d536098dbbd47a0c804f9482
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2875205
Reviewed-by: Patrick Thier <[email protected]>
Commit-Queue: Milad Fa <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#47}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Merged: [debug] correctly tier down function for side effect check mode
Revision: dc49fe0

Merged: Fix test expectation for new inspector test
Revision: 04ade0b

Merged: Skip regress-crbug-1233401 for jitless mode
Revision: 06ae019

BUG=chromium:1233401
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I26171779ade8e6c15c57ce404dbae74b70734112
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3064608
Reviewed-by: Kim-Anh Tran <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#47}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
The tests are:
  test/mjsunit/regress/regress-crbug-1161847-1.js
  test/mjsunit/regress/regress-crbug-1161847-2.js

added by https://chromium-review.googlesource.com/c/v8/v8/+/2748079

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Bug: chromium:1161847
Change-Id: Ida12c27ea7ee1fec7c63ab541e96d1b0a26de473
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783021
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#47}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I51c6f1a2b8444d161e69486843ff933dc212dca8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233918
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#47}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I36fa2482d99aa84ad6809556ee4e9dd8aa37e0b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3242224
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#47}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I0ad2893aee26103315e595e2173f1cbdcee13940
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519302
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#47}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
The tests are:
  test/mjsunit/regress/regress-crbug-1161847-1.js
  test/mjsunit/regress/regress-crbug-1161847-2.js

added by https://chromium-review.googlesource.com/c/v8/v8/+/2748079

LTS notes: Moved to LTS section.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

(cherry picked from commit 88cbc23)

Bug: chromium:1161847
Change-Id: Ida12c27ea7ee1fec7c63ab541e96d1b0a26de473
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783021
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/8.9@{v8#47}
Cr-Original-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Original-Branched-From: d16a2a6-refs/heads/master@{#72039}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854736
Commit-Queue: Artem Sumaneev <[email protected]>
Reviewed-by: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#89}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
…owering"

This is a reland of 47077d9 without
changes. The revert was false alarm.

[M86]: Resolved simple conflicts.

Original change's description:
> [compiler] Fix more truncation bugs in SimplifiedLowering
>
> Bug: chromium:1200490
> Change-Id: I3555b6d99bdb4b4e7c302a43a82c17e8bff84ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2840452
> Reviewed-by: Nico Hartmann <[email protected]>
> Commit-Queue: Georg Neis <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#74097}

(cherry picked from commit e4a580c)

(cherry picked from commit 97ad045)

Bug: chromium:1200490
Tbr: [email protected]
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Iedddcf2d0117fa59dc9d7a3604ef203808ad2903
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850159
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/9.0@{v8#47}
Cr-Original-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Original-Branched-From: 349bcc6-refs/heads/master@{#73001}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2883780
Reviewed-by: Jana Grill <[email protected]>
Commit-Queue: Victor-Gabriel Savu <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#95}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: I7ac56dd243381fa3f8635bb2211068bd9a23c124
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439634
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#47}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
…ring"

This is a reland of 47077d9 without
changes. The revert was false alarm.

Original change's description:
> [compiler] Fix more truncation bugs in SimplifiedLowering
>
> Bug: chromium:1200490
> Change-Id: I3555b6d99bdb4b4e7c302a43a82c17e8bff84ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2840452
> Reviewed-by: Nico Hartmann <[email protected]>
> Commit-Queue: Georg Neis <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#74097}

(cherry picked from commit e4a580c)

Bug: chromium:1200490
Tbr: [email protected]
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Iedddcf2d0117fa59dc9d7a3604ef203808ad2903
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850159
Reviewed-by: Georg Neis <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#47}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Merged: [mips] Support unaligned loading and storing kWord8 value
Revision: 656a687

Merged: [mips] Fix floating point abs operation
Revision: 90f9dec

Merged: [mips32] Fix Float64 Abs operation
Revision: 471a893

Bug: v8:11125
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I69ef8e779215a41674b91d2e73a32854a24ad82a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2524302
Reviewed-by: Zhi An Ng <[email protected]>
Commit-Queue: Zhi An Ng <[email protected]>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#47}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Otherwise it's propagated to the parent

(cherry picked from commit e1e0890)

Bug: chromium:1394973
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I178f9d5d863aec501525a783846d1df6d3031bb2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4100687
Commit-Queue: Toon Verwaest <[email protected]>
Auto-Submit: Toon Verwaest <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#84808}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4143040
Commit-Queue: Roger Felipe Zanoni da Silva <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#47}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
... by using JavaScript spec compliant JSReceiver::DefineOwnProperty.

Drive-by:
- cleanup comments in include/v8-object.h, insert links to
respective pages of https://tc39.es/ecma262/ when referencing spec,
- rename JSObject::DefineAccessor() to
  JSObject::DefineOwnAccessorIgnoreAttributes().

Bug: chromium:1433211
(cherry picked from commit b8020e1)

Change-Id: Ia4e0389e99b5a79987f59ca2a11ee7867b0c97e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4502585
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.2@{v8#47}
Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1}
Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Bug: chromium:1377816
(cherry picked from commit f517e51)

Change-Id: I993bcff0389a1ba134e89e8ac5299d742ddd150c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3999134
Commit-Queue: Thibaud Michaud <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#47}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Change-Id: I8c928228c51f32689687b3929439a214d3cd4a1e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4111702
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#47}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I79ccb8d1e438726c77d981ad9e66c163c90cd8c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060749
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.0@{v8#47}
Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2}
Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I3832ca3a3882adc1a2d35edb2e2edffcc5e0c8bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411577
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#47}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 24, 2023
Bug: chromium:1452137
(cherry picked from commit c7c4477)

Change-Id: I611c41f942e2e51f3c4b4f1d119c18410617188e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4637888
Commit-Queue: Igor Sheludko <[email protected]>
Auto-Submit: Igor Sheludko <[email protected]>
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#47}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch Bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 21, 2024
No-Try: true
Bug: b/319667336
Change-Id: I302fa061ebab15a24a5db51650559dab1193fa13
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5197110
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Michael Achenbach <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#47}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Mar 20, 2024
Change-Id: I086f8fac8bbadbb698b971cd13185a240c8a19cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5383688
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.2@{#47}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request Apr 10, 2024
Change-Id: I8297eea273d0ae795bd255d68ac5f8d965ce44f0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5440226
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.0@{#47}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request Jul 5, 2024
Change-Id: I7254fcc564c06e8e493be35e49205356f331ee24
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679267
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.6@{#47}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Aug 26, 2024
Change-Id: I7daa8f5ccc9e86de51686f686628d75858d24f26
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5812172
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.8@{#47}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Sep 26, 2024
This reverts commit 62605e1.

Reason for revert: https://crbug.com/369374536

Original change's description:
> [maps] Re-enable side-step transitions
>
> Bug: 40764103
> Change-Id: Ie380d54e00a38cf8e8937990af321bc7e498d686
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5667163
> Auto-Submit: Olivier Flückiger <[email protected]>
> Commit-Queue: Olivier Flückiger <[email protected]>
> Reviewed-by: Igor Sheludko <[email protected]>
> Commit-Queue: Igor Sheludko <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#94738}

Bug: 40764103
Fixed: 369374536
(cherry picked from commit a7766fe)

Change-Id: I59508a3af0fd6b55cdfe044fc866eb1dc185ea26
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5891172
Reviewed-by: Patrick Thier <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/12.9@{#47}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Dec 16, 2024
… properly

While https://crrev.com/c/6087921 fixed a bug where the type in the
loop header revisit was reflecting "older" knowledge, it didn't address
the general issue of loop phis dependencies in single block loops where
it might require many iterations until all type information has
stabilized.

The fix linked above also introduce too specific DCHECKs, as even
outside of single-block loops we can end up with phis where a phi input
appears in the same block before the phi itself.
The binaryen fuzzer found the following pattern:
  v113 = Phi(v26, v113)
  v114 = Phi(v26, v113)

In follow-up changes it should be ensured that the useless phi v113
doesn't get emitted, then v114 wouldn't have that issue (and it could
also be removed.)

(cherry picked from commit c84e01e)

Fixed: 383356864
Bug: 383814042
Change-Id: I222dc493bf0a2613d14ebb7df2bdeca931c8daa6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097772
Auto-Submit: Jakob Kummerow <[email protected]>
Commit-Queue: Eva Herencsárová <[email protected]>
Reviewed-by: Eva Herencsárová <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.0@{#47}
Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1}
Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot pushed a commit that referenced this pull request Dec 20, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728037962622053729

Change-Id: Ibabc247f0d5969ce11953f615d9444ba0737fd94
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6108232
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.2@{#47}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jul 7, 2025
…t count

The scope prevents veneer pool generation. We need to pass the
correct count of instructions to CheckVeneerPool inside the scope
constructor, otherwise we might overflow the veneer distance
margin in the next check (after the scope has ended).

Bug: 425583995

(cherry picked from commit c58fda1)

Change-Id: I95cf184422d3b62c222aa378148337884047f9e7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6701570
Commit-Queue: Leszek Swirski <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Auto-Submit: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/branch-heads/13.8@{#47}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot pushed a commit that referenced this pull request Feb 2, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8690960399974724241

Change-Id: Ifcdbd6ad2e6269ce43a1493e75d4e97fbadfd602
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7537989
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/14.4@{#47}
Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1}
Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
hubot pushed a commit that referenced this pull request Mar 19, 2026
NO_IFTTT=Other site is ok

Fixed: 487213150
(cherry picked from commit dec3cff)

Change-Id: I78de2ada515c180320167da1526b6509ddde0467
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7679312
Reviewed-by: Igor Sheludko <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Auto-Submit: Olivier Flückiger <[email protected]>
Commit-Queue: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/branch-heads/14.6@{#47}
Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1}
Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
hubot pushed a commit that referenced this pull request May 12, 2026
…isions)

https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/2145cedef4ca..91552391bf2f

2026-05-06 [email protected] Fix wrong update-ui performance.mark and measure nesting
2026-03-26 [email protected] Improve memory script
2026-03-19 [email protected] Address comments for memory measurement script
2026-03-19 [email protected] Add memory measurement script
2026-03-18 [email protected] Actually fix --dump-test-list
2026-03-18 [email protected] Fix --dump-test-list and --test in v3.0-custom
2026-03-17 [email protected] Update v3.0-custom to latest v3.0 branch
2026-01-30 [email protected] Merge pull request #272 from danleh/JetStream3.0
2026-01-19 [email protected] Reland: Improve Benchmark constructor and instance variables #255 (#263)
2026-01-19 [email protected] Reland: Add resource loading bar  (#264)
2026-01-19 [email protected] Merge pull request #261 from danleh/dotnet-mime-fix
2026-01-17 [email protected] Merge pull request #262 from kmiller68/revert-replace-prefetch-logic
2026-01-15 [email protected] Merge pull request #245 from kmiller68/add-open-governance-policy
2026-01-15 [email protected] Merge pull request #260 from danleh/readme-addendum
2026-01-14 [email protected] Merge pull request #258 from danleh/repo-readme
2026-01-14 [email protected] Improve Benchmark constructor and instance variables (#255)
2026-01-14 [email protected] Merge pull request #254 from kmiller68/scatter-plot-should-increase-with-score
2026-01-14 [email protected] Merge pull request #257 from danleh/remove-unused-deps
2026-01-14 [email protected] Fix dev server output (#252)
2026-01-14 [email protected] Merge pull request #256 from danleh/fix-npm-audit
2026-01-14 [email protected] Add resource loading bar (#246)
2026-01-13 [email protected] Replace prefetch logic (#251)
2026-01-06 [email protected] Merge pull request #249 from kmiller68/add-verbose-option-to-server
2026-01-06 [email protected] Add BrowserFileLoader (#242)
2025-12-18 [email protected] Add --force-gc support (#248)
2025-12-10 [email protected] Merge pull request #244 from kmiller68/nonStandard-error-rotate-back-to-red
2025-12-10 [email protected] fewer shell warnings (#234)
2025-11-13 [email protected] Merge pull request #238 from kmiller68/transformers-js-loads-resources-at-runtime
2025-11-13 [email protected] Merge pull request #239 from Constellation/mod-256
2025-11-12 [email protected] Merge pull request #225 from kmiller68/reduce-kotlin-iteration-count
2025-11-07 [email protected] Merge pull request #236 from Constellation/use-integer
2025-11-05 [email protected] sync-fs and async-fs improvements (#217)
2025-11-04 [email protected] More ubuntu tests (#235)
2025-11-04 [email protected] Merge pull request #188 from kmiller68/dotnet-legacy-exceptions
2025-10-30 [email protected] Github Workflow: split tests (#227)
2025-10-30 [email protected] Enable mobx-startup (#233)
2025-10-30 [email protected] More top-level cleanup (#229)
2025-10-30 [email protected] Improve preload code (#230)
2025-10-30 [email protected] Merge pull request #226 from kmiller68/console-warn-and-error-stderr-clis
2025-10-30 [email protected] Fix npm run test:build (#232)
2025-10-30 [email protected] Merge pull request #212 from kmiller68/disable-whisper-wasm
2025-10-29 [email protected] New Workload: Babylon class-heavy workload (#143)
2025-10-29 [email protected] Avoid new Date and improve filename extraction in doxbee benchmarks (#231)
2025-10-28 [email protected] New Workload: mobx observer + startup (#151)
2025-10-28 [email protected] StartupBenchmark refactoring (#218)
2025-10-27 [email protected] Add post-quit sleep for Safari (#220)
2025-10-27 [email protected] Enable jsdom-d3-startup by default. (#223)
2025-10-27 [email protected] More consistent LICENSE.txt files (#221)
2025-10-27 [email protected] Move more code to utils (#219)
2025-10-23 [email protected] Add npm run test:build script (#189)
2025-10-23 [email protected] Merge pull request #216 from kmiller68/total-to-overall-summary
2025-10-23 [email protected] render non default params (#197)
2025-10-23 [email protected] New Workload: JSDOM + d3 (#124)
2025-10-22 [email protected] Update test.yml (#190)
2025-10-22 [email protected] Await driver.quit (#209)
2025-10-22 [email protected] Add explicit version checks (#211)
2025-10-22 [email protected] Improve iterationCount and worstCaseCount params parsing (#215)
2025-10-22 [email protected] More consistent total score printing (#213)
2025-10-22 [email protected] Do not trigger logo animations again after loading all resources (#214)
2025-10-22 [email protected] support startAutomatically (#201)
2025-10-22 [email protected] Conditionally show more metric details (#167)
2025-10-22 [email protected] fix gaussian-blur input data (#207)
2025-10-22 [email protected] Improve tags (#206)
2025-10-22 [email protected] update selenium-webdriver version (#208)
2025-10-21 [email protected] Auto decompress files as part of test running (#195)
2025-10-17 [email protected] Support multiple comma separate tests in URL params (#198)
2025-10-15 [email protected] Merge pull request #77 from Constellation/base64
2025-10-15 [email protected] Fix prismjs sample file name(#202)
2025-10-08 [email protected] Add prettier config (#176)
2025-10-07 [email protected] Merge pull request #170 from eqrion/zlib-compress
2025-10-03 [email protected] Merge pull request #194 from victorvianna/main
2025-10-03 [email protected] Change shouldReport to report back
2025-10-03 [email protected] Compact display for non-default params (#191)
2025-10-01 [email protected] Add group-details parameter to conditionally display grouped benchmarks (#157)
2025-10-01 [email protected] New Workload: prismjs source code highlighting (#149)
2025-10-01 [email protected] New Workload: validatorjs regexp heavy workload (#147)
2025-09-23 [email protected] Merge pull request #192 from Constellation/dump-test-list
2025-09-22 [email protected] New Workload: TypeScript standalone (#117)
2025-09-19 [email protected] Merge pull request #187 from kmiller68/fix-web-ssr-for-options-bag
2025-09-17 [email protected] Test is causing jetsams on iOS. Disabling for now while I investigate.
2025-09-17 [email protected] Add JetStreamParams (#171)
2025-09-17 [email protected] New Workload: React Server Side Rendering Startup (#116)
2025-09-17 [email protected] Merge pull request #130 from danleh/j2cl-box2d
2025-09-16 [email protected] Merge pull request #182 from danleh/recompile-dotnet
2025-09-16 [email protected] Merge pull request #148 from danleh/transformersjs-rebase
2025-09-11 [email protected] Experimental Workload: Intl (#146)
2025-09-10 [email protected] Merge pull request #178 from danleh/disable-gcc-loops-quicksort
2025-09-08 [email protected] Merge pull request #168 from kmiller68/reduce-dotnet-runtime
2025-09-03 [email protected] More consistent metric reporting  (#175)
2025-09-03 [email protected] Minor browser test improvements (#177)
2025-09-03 [email protected] Merge pull request #173 from danleh/text-decoder-polyfill-move
2025-09-03 [email protected] Remove unused scripts (#174)
2025-09-02 [email protected] Merge pull request #172 from danleh/compress-js
2025-09-01 [email protected] Update/rewrite web-tooling-benchmark (#153)
2025-09-01 [email protected] Support custom benchmark arguments (#165)
2025-09-01 [email protected] Status update and CSS fixes (#169)
2025-08-27 [email protected] Use event.key instead of event.which #166
2025-08-27 [email protected] Merge pull request #144 from danleh/logo-text-to-path
2025-08-26 [email protected] StartupBenchmark: add better assertion failures (#164)
2025-08-26 [email protected] Add UTF16 sources test (#162)
2025-08-26 [email protected] Convert startup-helper/BabelCacheBuster.js to esm (#163)
2025-08-26 [email protected] Add startup benchmark helper  (#158)
2025-08-20 [email protected] Merge pull request #159 from danleh/dotnet-wasm-rename
2025-08-15 [email protected] Expose JetStream global to workloads (#139)
2025-08-15 [email protected] Merge pull request #145 from Constellation/tfjs
2025-08-14 [email protected] Only expose a console copy in the realm (#137)
2025-08-14 [email protected] Merge pull request #133 from kmiller68/add-grouped-benchmark-for-sunspider
2025-08-14 [email protected] Merge pull request #142 from danleh/Dart-remove-unused-runner
2025-08-14 [email protected] Merge pull request #140 from danleh/disable-HashSet-wasm
2025-08-14 [email protected] merge async-fs code (#135)
2025-08-14 [email protected] Enable UniPoker validation by default (#141)
2025-08-14 [email protected] Merge pull request #138 from danleh/kotlin-fix-isD8-access
2025-08-14 [email protected] Bump selenium-webdriver version (#136)
2025-08-14 [email protected] Merge pull request #97 from eqrion/dart-todomvc
2025-08-14 [email protected] Improve console (#131)
2025-08-14 [email protected] Improve runner code (#134)
2025-08-14 [email protected] Rename worst4 to just worst (#129)
2025-08-13 [email protected] Merge pull request #127 from Constellation/list
2025-08-13 [email protected] Merge pull request #84 from danleh/kotlin
2025-08-12 [email protected] CSS fixes for info button (#126)
2025-08-12 [email protected] Add info-button (#123)
2025-08-11 [email protected] Merge pull request #119 from Constellation/set-status
2025-08-11 [email protected] Display workload scatterplots (#120)
2025-08-11 [email protected] Update .gitignore (#121)
2025-08-07 [email protected] Merge pull request #115 from kmiller68/fix-bencharks-by-tag-testlist
2025-08-06 [email protected] Configurable resource prefetching  (#70)
2025-08-06 [email protected] github workflow: keep running all tests even if there are failures (#114)
2025-08-05 [email protected] Add Scripts helper classes (#109)
2025-08-05 [email protected] Add three.js benchmark (#75)
2025-08-04 [email protected] Add validate method for async-fs and sync-fs (#111)
2025-08-04 [email protected] Add more performance.measure (#110)
2025-07-31 [email protected] Remove LuaJSFight  micro benchmarks (#104)
2025-07-31 [email protected] Add cli flags (#101)
2025-07-31 [email protected] Cleanup performance.now shimming (#108)
2025-07-30 [email protected] Formatting (#105)
2025-07-30 [email protected] Run all disabled workloads in tests (#103)
2025-07-30 [email protected] Add benchmarks argument to Driver (#98)
2025-07-29 [email protected] Merge pull request #102 from kmiller68/reenable-dotnet-tests
2025-07-29 [email protected] Simplify updateUIAfterRun (#99)
2025-07-29 [email protected] Merge customTestList and testList (#100)
2025-07-29 [email protected] Use tags for workload selection (#82)
2025-07-23 [email protected] Merge pull request #93 from danleh/cleanup-loadInternal
2025-07-23 [email protected] Merge pull request #73 from maraf/DotnetWasm
2025-07-21 [email protected] Fix typo in headers fetch request  (#80)
2025-07-15 [email protected] use default performance.measure implementation (#83)
2025-07-15 [email protected] Use subScores directly for the UI (#81)
2025-07-15 [email protected] Add basic unittests (#94)
2025-07-14 [email protected] Fix accidental loading status clipping in wide windows (#85)
2025-07-14 [email protected] Simplify formatting (#79)
2025-07-12 [email protected] Merge pull request #90 from kmiller68/fix-prepareForNextIteration-async-benchmark
2025-07-10 [email protected] Merge pull request #74 from kmiller68/preload-blobs-wasm
2025-07-08 [email protected] Merge pull request #76 from kmiller68/zlib-check-_compressFile-to-setupModule
2025-07-02 [email protected] Revert #78 as it broke JetStream3 on web page
2025-07-02 [email protected] Remove custom run methods #78
2025-06-04 [email protected] Merge pull request #72 from Constellation/new-string
2025-05-13 [email protected] Merge pull request #71 from kmiller68/disable-extra-bigint-tests
2025-05-13 [email protected] Merge pull request #65: OfflineAssembler: Avoid accidental toString operation
2025-05-13 [email protected] Merge pull request #64: WSL: Add performance.mark
2025-05-13 [email protected] Merge pull request #60: date-format: Add result hashing to prevent DCE
2025-05-13 [email protected] Merge pull request #62: Avoid eval in date-format-tofte
2025-05-05 [email protected] Merge pull request #53 from mkustermann/js-strings
2025-04-24 [email protected] Merge pull request #67 from issackjohn/issack/add-edge
2025-04-24 [email protected] Merge pull request #61 from camillobruni/2025-03-26_gbemu_hash
2025-04-07 [email protected] Merge pull request #59 from camillobruni/2025-03-26_cli_error_handling
2025-04-07 [email protected] Merge pull request #42 from camillobruni/2025-01-28_cli_tests
2025-04-07 [email protected] Merge pull request #41 from camillobruni/2025-01-28_runner_log
2025-04-07 [email protected] Merge pull request #14 from camillobruni/2024-11-26_tags
2025-03-12 [email protected] Merge pull request #57 from kmiller68/module-url-fix-v2
2025-02-27 [email protected] Merge pull request #51 from danleh/main
2025-02-27 [email protected] Merge pull request #52 from kmiller68/pathname-browser-dart
2025-02-26 [email protected] Merge pull request #33 from danleh/dart-flute-wasm-squash
2025-02-26 [email protected] Merge pull request #47 from kmiller68/argon2-to-js-scoring-v2
2025-02-26 [email protected] Merge pull request #40 from danleh/8bitbench-wasm-scoring
2025-02-12 [email protected] Merge pull request #43 from danleh/zlib-wasm
2025-02-10 [email protected] Merge pull request #45 from danleh/richards-workload-size-as-input
2025-02-07 [email protected] Merge pull request #44 from danleh/wasm-workload-sizes
2025-01-28 [email protected] Merge pull request #39 from camillobruni/2025-01-28_test_runner_fix
2025-01-27 [email protected] Merge pull request #35 from danleh/hashset-wasm-scoring
2025-01-27 [email protected] Merge pull request #30 from danleh/sqlite-scoring
2025-01-27 [email protected] Merge pull request #28 from danleh/quicksort-wasm-scoring
2025-01-27 [email protected] Merge pull request #37 from WebKit/remove-octane-zlib
2025-01-24 [email protected] Revert "Remove Octane-zlib."
2025-01-24 [email protected] Remove Octane-zlib.
2025-01-24 [email protected] Merge pull request #13 from camillobruni/2024-11-22_driver_prep
2025-01-24 [email protected] Merge pull request #11 from camillobruni/2024-11-26_github_actions
2025-01-23 [email protected] Merge pull request #27 from danleh/richards-js-scoring
2025-01-22 [email protected] Merge pull request #34 from WebKit/fix-report-JSON
2025-01-22 [email protected] Merge pull request #32 from danleh/performance-mark-measure
2025-01-21 [email protected] Merge pull request #31 from WebKit/revert-tfjs-to-js-scoring
2025-01-21 [email protected] Merge pull request #16 from camillobruni/2024-11-26_ms
2025-01-21 [email protected] Merge pull request #26 from danleh/gcc-loops-js-scoring
2025-01-16 [email protected] Merge pull request #23 from WebKit/tfjs-to-js-scoring
2025-01-16 [email protected] Merge pull request #17 from camillobruni/2024-11-26_safe_add
2025-01-16 [email protected] Merge pull request #25 from danleh/spidermonkey-cli-fix
2025-01-08 [email protected] Merge pull request #21 from WebKit/remove-float-mm-c
2024-12-21 [email protected] Merge pull request #18 from WebKit/wasm-benchmarks-should-be-scored-like-js-benchmarks
2024-12-20 [email protected] Merge pull request #2 from danleh/sqlite-wasm
2024-12-09 [email protected] Merge pull request #5 from camillobruni/2024-11-22_runner_improvements
2024-12-09 [email protected] Merge pull request #8 from camillobruni/2024-11-22_regexp
2024-12-09 [email protected] Merge pull request #19 from camillobruni/2024-11-27_async_fs
2024-11-26 [email protected] Merge pull request #7 from camillobruni/2024-11-22_driver_vars
2024-11-25 [email protected] Merge pull request #4 from camillobruni/2024-11-22_3dcube_fix
2024-11-25 [email protected] Merge pull request #6 from camillobruni/2024-11-22_gitignore
2024-11-13 [email protected] Merge pull request #1 from danleh/main
2024-10-30 [email protected] Initial copy from WebKit/PerformanceTests/JetStream3
2024-10-30 [email protected] Initial commit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/jetstream-v3-0-custom-v8
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in JetStream v3.0-custom: https://issues.chromium.org/u/1/issues/new?component=1741045&pli=1&template=0
To file a bug in V8: https://issues.chromium.org/u/1/issues/new?component=1456824&pli=1&template=2109136

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: [email protected],[email protected]
Change-Id: Ic53c7e030a05111ba56e03ab158282762aa17360
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7823185
Commit-Queue: Camillo Bruni <[email protected]>
Bot-Commit: [email protected] <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#107273}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants