Skip to content

[vector_graphics] Remove unnecessary Material imports - #12798

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ricardodalarme:refactor/vector_graphics/remove-unnecessary-material-cupertino-imports
Sep 29, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
ricardodalarme:refactor/vector_graphics/remove-unnecessary-material-cupertino-imports

Conversation

@ricardodalarme

@ricardodalarme ricardodalarme commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Removes unnecessary material imports from vector_graphics to decouple vector_graphics from Material/Cupertino since they will eventually be removed from the core SDK.

Part of: flutter/flutter#191322

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the imports in packages/vector_graphics/test/caching_test.dart by replacing package:flutter/material.dart with package:flutter/widgets.dart. There are no review comments, and I have no feedback to provide.

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate why this is something we should do in the description please. You link another issue but you don't explain why it's related in a self contained manner.

@ricardodalarme
ricardodalarme force-pushed the refactor/vector_graphics/remove-unnecessary-material-cupertino-imports branch from c8f2c68 to 0089c80 Compare September 28, 2026 15:16
@ricardodalarme

ricardodalarme commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author

@gaaclarke the idea is to essentially decouple vector_graphics from Material/Cupertino because they will eventually be removed from the core SDK. So this ensures that this package won't unnecessarily depend on any design system package

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaaclarke
gaaclarke requested a review from walley892 September 28, 2026 15:59
@gaaclarke

Copy link
Copy Markdown
Member

@walley892 can you be my second here please

@ricardodalarme
ricardodalarme force-pushed the refactor/vector_graphics/remove-unnecessary-material-cupertino-imports branch from 0089c80 to 951c027 Compare September 29, 2026 14:45
@gaaclarke gaaclarke added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Sep 29, 2026
@auto-submit
auto-submit Bot merged commit da4e442 into flutter:main Sep 29, 2026
13 checks passed
Istiak-Ahmed78 pushed a commit to Istiak-Ahmed78/flutter that referenced this pull request Sep 30, 2026
…er#193578)

flutter/packages@3c6ce59...0ba9a82

2026-09-30 [email protected] [image_picker_ios] PR 1/5 Add
injectable protocol seams and migrate leaf native tests to Swift Testing
(flutter/packages#12897)
2026-09-30 [email protected] [material_ui]
Migrate M3 Dialog template to use new gen_defaults
(flutter/packages#12917)
2026-09-30 [email protected] [material_ui]
Migrate M3 FAB template to use new gen_defaults (flutter/packages#12921)
2026-09-30 [email protected] [material_ui]
Migrate M3 DatePicker template to use new gen_defaults
(flutter/packages#12914)
2026-09-29 [email protected] [material_ui] Document that
TextField.decoration is merged with InputDecorationTheme
(flutter/packages#12493)
2026-09-29 [email protected] [camera_android_camerax] Move
misplaced Javadoc above annotations (flutter/packages#13040)
2026-09-29 [email protected] [vector_graphics] Remove
unnecessary Material imports (flutter/packages#12798)
2026-09-29 [email protected] Roll Flutter from
c5a061b to 55b8f88 (8 revisions) (flutter/packages#13066)
2026-09-29 [email protected] [webview_flutter_wkwebview]
Regenerate with pigeon 29.0.4 (flutter/packages#12923)
2026-09-29 [email protected] [url_launcher] Convert unit tests to
Kotlin (flutter/packages#13018)
2026-09-29 [email protected] [material_ui, cupertino_ui] Fix unresolved
doc comment references (flutter/packages#13044)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: vector_graphics triage-engine Should be looked at in engine triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants