Repository navigation
[camera_android_camerax] Move misplaced Javadoc above annotations - #13040
Conversation
The Javadoc for DeviceOrientationManager.createOrientationEventListener was placed after its annotations, so it was not attached to the method. javac 23+ reports this with the new dangling-doc-comments lint, which breaks the example app's -Xlint:all -Werror build on JDK 25.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the camera_android_camerax package to version 0.7.5+1 and resolves a build failure on JDK 23+ by moving the @VisibleForTesting and @NonNull annotations below the Javadoc comment for createOrientationEventListener in DeviceOrientationManager.java. There are no review comments, and I have no feedback to provide.
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
No need for the changelog/pubspec update! otherwise lgtm
This reverts commit b8decaf.
jesswrd
added
override: no versioning needed
jesswrd
added
the
autosubmit
…er#193578) flutter/packages@3c6ce59...0ba9a82 2026-09-30 [email protected] [image_picker_ios] PR 1/5 Add injectable protocol seams and migrate leaf native tests to Swift Testing (flutter/packages#12897) 2026-09-30 [email protected] [material_ui] Migrate M3 Dialog template to use new gen_defaults (flutter/packages#12917) 2026-09-30 [email protected] [material_ui] Migrate M3 FAB template to use new gen_defaults (flutter/packages#12921) 2026-09-30 [email protected] [material_ui] Migrate M3 DatePicker template to use new gen_defaults (flutter/packages#12914) 2026-09-29 [email protected] [material_ui] Document that TextField.decoration is merged with InputDecorationTheme (flutter/packages#12493) 2026-09-29 [email protected] [camera_android_camerax] Move misplaced Javadoc above annotations (flutter/packages#13040) 2026-09-29 [email protected] [vector_graphics] Remove unnecessary Material imports (flutter/packages#12798) 2026-09-29 [email protected] Roll Flutter from c5a061b to 55b8f88 (8 revisions) (flutter/packages#13066) 2026-09-29 [email protected] [webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 (flutter/packages#12923) 2026-09-29 [email protected] [url_launcher] Convert unit tests to Kotlin (flutter/packages#13018) 2026-09-29 [email protected] [material_ui, cupertino_ui] Fix unresolved doc comment references (flutter/packages#13044) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Moved comments above the annotations to fix
dangling-doc-commentscompiler warning. This is part of the work to ensure packages works on JDK 25.JDK 25's compiler added a
dangling-doc-commentsis a javac lint check that was new in JDK 23 (JDK-8303689) that warns when a Javadoc comment isnt attached to class, method, or field.Partially Addresses flutter/flutter#193404
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2