Repository navigation
[webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 - #12923
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the webview_flutter_wkwebview package version to 3.26.2 and upgrades the pigeon dependency to ^29.0.2 to resolve a crash related to WKNavigationDelegate authentication challenges. I have no feedback to provide as there were no review comments.
Picks up the Swift generator fix from flutter#12531, so a `WKNavigationDelegate.didReceiveAuthenticationChallenge` reply that the native instance manager can no longer resolve reports a `null-error` instead of force-casting `NSNull` and aborting the process.
067c93e to
59f9168
Compare
…view-regenerate-pigeon-29
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
I went ahead and ran the formatter on the PR to fix CI failures.
@LongCatIsLooong / @hellohuanlin for secondary review.
bparrishMines
changed the title
LongCatIsLooong
added
the
autosubmit
…er#193578) flutter/packages@3c6ce59...0ba9a82 2026-09-30 [email protected] [image_picker_ios] PR 1/5 Add injectable protocol seams and migrate leaf native tests to Swift Testing (flutter/packages#12897) 2026-09-30 [email protected] [material_ui] Migrate M3 Dialog template to use new gen_defaults (flutter/packages#12917) 2026-09-30 [email protected] [material_ui] Migrate M3 FAB template to use new gen_defaults (flutter/packages#12921) 2026-09-30 [email protected] [material_ui] Migrate M3 DatePicker template to use new gen_defaults (flutter/packages#12914) 2026-09-29 [email protected] [material_ui] Document that TextField.decoration is merged with InputDecorationTheme (flutter/packages#12493) 2026-09-29 [email protected] [camera_android_camerax] Move misplaced Javadoc above annotations (flutter/packages#13040) 2026-09-29 [email protected] [vector_graphics] Remove unnecessary Material imports (flutter/packages#12798) 2026-09-29 [email protected] Roll Flutter from c5a061b to 55b8f88 (8 revisions) (flutter/packages#13066) 2026-09-29 [email protected] [webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 (flutter/packages#12923) 2026-09-29 [email protected] [url_launcher] Convert unit tests to Kotlin (flutter/packages#13018) 2026-09-29 [email protected] [material_ui, cupertino_ui] Fix unresolved doc comment references (flutter/packages#13044) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Description
Regenerates
webview_flutter_wkwebviewwith pigeon29.0.2, which contains the Swift generator fix from #12531.The generated
WKNavigationDelegate.didReceiveAuthenticationChallengereply handler now treatsNSNullas a null reply, so a response the nativePigeonInstanceManagercan no longer resolve reports anull-errorinstead of force-casting and aborting the process:The diff is large because the package was last generated with
27.3.2, so it also picks up the28.x/29.xgenerator changes; no hand-written code needed updating.Verification
flutter analyzeis clean.NSNullcheck is present at theAuthenticationChallengeResponsecall site in the regeneratedWebKitLibrary.g.swift.Fixes flutter/flutter#191254
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is [exempt from CHANGELOG changes].///).