Skip to content

[material_ui, cupertino_ui] Fix unresolved doc comment references - #13044

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
szakarias:fix-material-ui-doc-references
Sep 29, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:mainfrom
szakarias:fix-material-ui-doc-references

Conversation

@szakarias

Copy link
Copy Markdown
Contributor

Companion to flutter/flutter#193283.
Applies the same fixes to the copies of these files in material_ui and cupertino_ui.

Doc comments only, so no version bump or changelog entry.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 28, 2026
@github-actions github-actions Bot added p: cupertino_ui p: material_ui triage-design Should be looked at in design triage labels Sep 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation comments across several files in the cupertino_ui and material_ui packages. Specifically, it adds missing @DocImport statements and refines inline documentation references to use fully qualified names (such as MaterialStateColor.resolve and Tooltip.message) or corrected formats. There are no review comments, so there is no feedback to provide.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are client-facing, so we typically have a changelog entry and a patch version bump IIRC. Can you add one? These packages use batch release, so you can use the pending changelog template

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2026
@auto-submit
auto-submit Bot merged commit 3561823 into flutter:main Sep 29, 2026
13 checks passed
Istiak-Ahmed78 pushed a commit to Istiak-Ahmed78/flutter that referenced this pull request Sep 30, 2026
…er#193578)

flutter/packages@3c6ce59...0ba9a82

2026-09-30 [email protected] [image_picker_ios] PR 1/5 Add
injectable protocol seams and migrate leaf native tests to Swift Testing
(flutter/packages#12897)
2026-09-30 [email protected] [material_ui]
Migrate M3 Dialog template to use new gen_defaults
(flutter/packages#12917)
2026-09-30 [email protected] [material_ui]
Migrate M3 FAB template to use new gen_defaults (flutter/packages#12921)
2026-09-30 [email protected] [material_ui]
Migrate M3 DatePicker template to use new gen_defaults
(flutter/packages#12914)
2026-09-29 [email protected] [material_ui] Document that
TextField.decoration is merged with InputDecorationTheme
(flutter/packages#12493)
2026-09-29 [email protected] [camera_android_camerax] Move
misplaced Javadoc above annotations (flutter/packages#13040)
2026-09-29 [email protected] [vector_graphics] Remove
unnecessary Material imports (flutter/packages#12798)
2026-09-29 [email protected] Roll Flutter from
c5a061b to 55b8f88 (8 revisions) (flutter/packages#13066)
2026-09-29 [email protected] [webview_flutter_wkwebview]
Regenerate with pigeon 29.0.4 (flutter/packages#12923)
2026-09-29 [email protected] [url_launcher] Convert unit tests to
Kotlin (flutter/packages#13018)
2026-09-29 [email protected] [material_ui, cupertino_ui] Fix unresolved
doc comment references (flutter/packages#13044)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants