Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3c6ce5905441
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0ba9a8241e40
Choose a head ref
  • 11 commits
  • 66 files changed
  • 9 contributors

Commits on Sep 29, 2026

  1. [material_ui, cupertino_ui] Fix unresolved doc comment references (#1…

    …3044)
    
    Companion to flutter/flutter#193283. 
    Applies the same fixes to the copies of these files in `material_ui` and `cupertino_ui`.
    
    Doc comments only, so no version bump or changelog entry.
    szakarias authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    3561823 View commit details
    Browse the repository at this point in the history
  2. [url_launcher] Convert unit tests to Kotlin (#13018)

    Converts `url_launcher_android` native unit tests from Java to Kotlin.
    
    Similar to my other conversions, the process was:
    - Use the Android Studio deterministic auto-conversion.
    - Do a bunch of manual cleanup, as separate commits by topic.
      - This included adopting `mockito-kotlin` to make the mocking much less verbose and complex
    - Do a local Gemini review for where the code could be improved as Kotlin code, and address most of that feedback.
    
    Does not include any changes to production code.
    
    Part of flutter/flutter#188630
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    5ef4d9e View commit details
    Browse the repository at this point in the history
  3. [webview_flutter_wkwebview] Regenerate with pigeon 29.0.4 (#12923)

    ## Description
    
    Regenerates `webview_flutter_wkwebview` with pigeon `29.0.2`, which contains the Swift generator fix from #12531.
    
    The generated `WKNavigationDelegate.didReceiveAuthenticationChallenge` reply handler now treats `NSNull` as a null reply, so a response the native `PigeonInstanceManager` can no longer resolve reports a `null-error` instead of force-casting and aborting the process:
    
    ```
    Could not cast value of type 'NSNull' (0x...) to 'webview_flutter_wkwebview.AuthenticationChallengeResponse' (0x...).
    ```
    
    The diff is large because the package was last generated with `27.3.2`, so it also picks up the `28.x`/`29.x` generator changes; no hand-written code needed updating.
    
    ## Verification
    
    * `flutter analyze` is clean.
    * All 154 unit tests pass.
    * The iOS example builds for the simulator.
    * The `NSNull` check is present at the `AuthenticationChallengeResponse` call site in the regenerated `WebKitLibrary.g.swift`.
    
    *Fixes flutter/flutter#191254
    
    ## Pre-Review Checklist
    Xelorium authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    db43d9f View commit details
    Browse the repository at this point in the history
  4. Roll Flutter from c5a061b18fa2 to 55b8f88e855f (8 revisions) (#13066)

    flutter/flutter@c5a061b...55b8f88
    
    2026-09-29 [email protected] [Android 17] Added Android 17 device to Firebase tests (flutter/flutter#193251)
    2026-09-29 [email protected] [engine] Fix remaining `unawaited_futures` lints (flutter/flutter#193508)
    2026-09-29 [email protected] shell: Rename first-frame tests AddFirstFrameCallback* (flutter/flutter#193418)
    2026-09-28 [email protected] Enable `unawaited_futures` lint across the Flutter repository (flutter/flutter#193125)
    2026-09-28 [email protected] Upgrade flutter/flutter to Roblectric 4.17 (flutter/flutter#193369)
    2026-09-28 [email protected] [engine] Decode animation frames with alpha after an opaque first frame (flutter/flutter#193113)
    2026-09-28 [email protected] Allow macOS tests to use macOS 15 or 26 (flutter/flutter#193317)
    2026-09-28 [email protected] Cleanup DDC SDK build targets (flutter/flutter#193193)
    
    If this roll has caused a breakage, revert this CL and set the roller
    to dry run mode using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC [email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    105b077 View commit details
    Browse the repository at this point in the history
  5. [vector_graphics] Remove unnecessary Material imports (#12798)

    Removes unnecessary `material` imports from `vector_graphics` to decouple `vector_graphics` from Material/Cupertino since they will eventually be removed from the core SDK.
    
    Part of: flutter/flutter#191322
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    ricardodalarme authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    da4e442 View commit details
    Browse the repository at this point in the history
  6. [camera_android_camerax] Move misplaced Javadoc above annotations (#1…

    …3040)
    
    Moved comments above the annotations to fix `dangling-doc-comments` compiler warning. This is part of the work to ensure packages works on JDK 25.
    
    JDK 25's compiler added a `dangling-doc-comments` is a javac lint check that was new in JDK 23 ([JDK-8303689](https://bugs.openjdk.org/browse/JDK-8303689)) that warns when a Javadoc comment isnt attached to class, method, or field.
    
    Partially Addresses flutter/flutter#193404
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    jesswrd authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    b0abd88 View commit details
    Browse the repository at this point in the history
  7. [material_ui] Document that TextField.decoration is merged with Input…

    …DecorationTheme (#12493)
    
    `TextField.decoration`'s dartdoc describes what the decoration draws, but never mentions that the value passed here is *combined* with the ambient `InputDecorationTheme` rather than replacing it.
    
    `TextField` builds its effective decoration with `InputDecoration.applyDefaults` (`packages/material_ui/lib/src/text_field.dart`), and `applyDefaults` only substitutes properties that are null on the incoming `InputDecoration` — including `border: border ?? theme.border` (`packages/material_ui/lib/src/input_decorator.dart`). So a theme-provided border survives an `InputDecoration` that simply omits one, which is surprising if you read the property docs alone. That confusion is what flutter/flutter#159629 reports.
    
    This adds a paragraph to the `decoration` property documenting the merge and pointing at the explicit opt-out (`InputBorder.none`).
    
    This covers the documentation half of flutter/flutter#159629. The issue also proposes a `mergeWithTheme`-style flag on `InputDecoration`; that is an API proposal and is deliberately left out of this PR, so the issue should stay open.
    
    Originally opened against `flutter/flutter` as flutter/flutter#191260, and moved here after the code-freeze bot pointed out that Material changes now belong in `material_ui`.
    
    *Documentation-only change; no behavior change and no new tests.*
    Treamz authored Sep 29, 2026
    Configuration menu
    Copy the full SHA
    78d4f12 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2026

  1. [material_ui] Migrate M3 DatePicker template to use new gen_defaults (#…

    …12914)
    
    Work toward flutter/flutter#187899.
    Fixes flutter/flutter#188410.
    
    Migrates the M3 DatePicker defaults template to the new packages/material_ui/tool/gen_defaults generator.
    
    ## Pre-Review Checklist
    QuncCccccc authored Sep 30, 2026
    Configuration menu
    Copy the full SHA
    af73549 View commit details
    Browse the repository at this point in the history
  2. [material_ui] Migrate M3 FAB template to use new gen_defaults (#12921)

    Work toward flutter/flutter#187899.
    Fixes flutter/flutter#188415.
    
    This PR migrates the M3 FloatingActionButton defaults template to use the new `gen_defaults` in `material_ui`. The generated defaults remain unchanged.
    
    ## Pre-Review Checklist
    QuncCccccc authored Sep 30, 2026
    Configuration menu
    Copy the full SHA
    bbc191c View commit details
    Browse the repository at this point in the history
  3. [material_ui] Migrate M3 Dialog template to use new gen_defaults (#12917

    )
    
    Work toward flutter/flutter#187899.
    Fixes flutter/flutter#188411.
    
    This PR migrates the M3 Dialog defaults template to the new packages/material_ui/tool/gen_defaults generator.
    
    ## Pre-Review Checklist
    QuncCccccc authored Sep 30, 2026
    Configuration menu
    Copy the full SHA
    46c8280 View commit details
    Browse the repository at this point in the history
  4. [image_picker_ios] PR 1/5 Add injectable protocol seams and migrate l…

    …eaf native tests to Swift Testing (#12897)
    
    Adds injectable protocol seams for camera, photo library, and PHPicker so later PRs can test without OCMock. Migrates the ImageUtil, MetaDataUtil, PhotoAssetUtil, and PHPicker save-operation tests to Swift Testing.
    
    Plugin behavior is unchanged. Native tests capture async `savedPathBlock` results and assert after `await`, so those expectations can fail CI.
    
    Bumps `image_picker_ios` to **0.8.13+8**.
    
    PR 1/5 of the Obj-C → Swift migration. Part of flutter/flutter#119107
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    victogomez-cs authored Sep 30, 2026
    Configuration menu
    Copy the full SHA
    0ba9a82 View commit details
    Browse the repository at this point in the history
Loading